public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM] updates the at91  main_clock calculation
Date: Wed, 17 Feb 2010 20:08:13 +0100	[thread overview]
Message-ID: <4B7C3E9D.6020607@scharsoft.de> (raw)
In-Reply-To: <4B7BA904.2090704@esd.eu>

Daniel Gorsulowski wrote:
>>> Jens Scharsig wrote:
> soft_i2c.c: In function 'send_reset':
> soft_i2c.c:103: warning: unused variable 'pio'
--snip--
> soft_i2c.c: In function 'read_byte':
> soft_i2c.c:259: warning: unused variable 'pio'

There are two ways to define  I2C_xxxx macros:
gpio or direct SoC access

if you are using gpio to define macros, I think you get this warnings.

If you are using direct SoC access (no gpio driver needed)
there are no warnings 
e.g.

#define I2C_ACTIVE	writel(AT91_PMX_AA_TWD, &pio->pioa.mddr);
#define I2C_TRISTATE	writel(AT91_PMX_AA_TWD, &pio->pioa.mder);
and so on

> atmel_dataflash_spi.c:25:2: warning: #warning Please update to use C structur
> SoC access !
> atmel_usart.c:21:2: warning: #warning Please update to use C structur SoC access !
> ohci-at91.c:30:2: warning: #warning Please update to use C structur SoC access !

We need some volunteers, which convert the drivers.

Regards Jens

  reply	other threads:[~2010-02-17 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14 11:20 [U-Boot] [PATCH ARM] updates the at91 main_clock calculation Jens Scharsig
2010-02-16  6:17 ` Daniel Gorsulowski
2010-02-16 15:23   ` Tom
2010-02-17  8:29     ` Daniel Gorsulowski
2010-02-17 19:08       ` Jens Scharsig [this message]
2010-02-17 21:17       ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7C3E9D.6020607@scharsoft.de \
    --to=js_at_ng@scharsoft.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox