From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Scharsig <js_at_ng@scharsoft.de>
Date: Wed, 17 Feb 2010 20:08:13 +0100
Subject: [U-Boot] [PATCH ARM] updates the at91  main_clock calculation
In-Reply-To: <4B7BA904.2090704@esd.eu>
References: <4B77DC8B.6050209@scharsoft.de>
	<4B7A3880.5020204@esd.eu>	<4B7AB874.7030601@windriver.com>
	<4B7BA904.2090704@esd.eu>
Message-ID: <4B7C3E9D.6020607@scharsoft.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Daniel Gorsulowski wrote:
>>> Jens Scharsig wrote:
> soft_i2c.c: In function 'send_reset':
> soft_i2c.c:103: warning: unused variable 'pio'
--snip--
> soft_i2c.c: In function 'read_byte':
> soft_i2c.c:259: warning: unused variable 'pio'

There are two ways to define  I2C_xxxx macros:
gpio or direct SoC access

if you are using gpio to define macros, I think you get this warnings.

If you are using direct SoC access (no gpio driver needed)
there are no warnings 
e.g.

#define I2C_ACTIVE	writel(AT91_PMX_AA_TWD, &pio->pioa.mddr);
#define I2C_TRISTATE	writel(AT91_PMX_AA_TWD, &pio->pioa.mder);
and so on

> atmel_dataflash_spi.c:25:2: warning: #warning Please update to use C structur
> SoC access !
> atmel_usart.c:21:2: warning: #warning Please update to use C structur SoC access !
> ohci-at91.c:30:2: warning: #warning Please update to use C structur SoC access !

We need some volunteers, which convert the drivers.

Regards Jens