public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM] updates the at91  main_clock calculation
Date: Wed, 17 Feb 2010 15:17:38 -0600	[thread overview]
Message-ID: <4B7C5CF2.7040506@windriver.com> (raw)
In-Reply-To: <4B7BA904.2090704@esd.eu>

Daniel Gorsulowski wrote:
> Am 16.02.2010 16:23, schrieb Tom:
>> Daniel Gorsulowski wrote:
>>> Jens Scharsig wrote:
>>>>  * updates the conditional main_clock calculation (if AT91_MAIN_CLOCK defined) to c structure SoC access
>>>>  * add need register flags
>>>>
>>>>
>>>> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
>>>> ---
>>>>  cpu/arm926ejs/at91/clock.c           |    7 ++++---
>>>>  include/asm-arm/arch-at91/at91_pmc.h |    3 +++
>>>>  2 files changed, 7 insertions(+), 3 deletions(-)
>>>>
>>> ...
>>>
>>> Thank you, now the updated otc570 builds without errors.
>>> I didn't check, whether the board boots, but I guess it does.
>>>
>> Were you going to check in the next couple of days ?
>> Tom
>>
>>
> Checked... board boots.
> 

Thanks!

> Btw. there are some warnings during build:
> mkimage.c: In function ?main?:
> mkimage.c:204: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> mkimage.c:222: warning: dereferencing type-punned pointer will break

In general I look for new compiler warnings and errors.
Any old warnings should be fixed but it is unlikely that
this change introduced them.

Of course results will vary depending on toolchain.

Thanks,
Tom

> 
> Regards,
> Daniel

      parent reply	other threads:[~2010-02-17 21:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14 11:20 [U-Boot] [PATCH ARM] updates the at91 main_clock calculation Jens Scharsig
2010-02-16  6:17 ` Daniel Gorsulowski
2010-02-16 15:23   ` Tom
2010-02-17  8:29     ` Daniel Gorsulowski
2010-02-17 19:08       ` Jens Scharsig
2010-02-17 21:17       ` Tom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7C5CF2.7040506@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox