public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] my recent i2c patches
@ 2010-02-24 19:32 Frans Meulenbroeks
  2010-02-24 19:51 ` Eric Bénard
  2010-02-24 20:31 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Frans Meulenbroeks @ 2010-02-24 19:32 UTC (permalink / raw)
  To: u-boot

One word wrt the i2c patches I just mailed.
It was my impression that git send-email would include the number in
the patch but as can be seen that was not the case.

The patches are to be applied in the following order:
0001-cmd_i2c.c-reduced-subaddress-length-to-3-bytes.patch
0002-cmd_bootm.c-made-subcommand-array-static.patch
0003-cmd_i2c.c-reworked-subcommand-handling.patch
0004-cmd_i2c.c-sorted-commands-alphabetically.patch
0005-cmd_i2c.c-added-i2c-read-to-memory-function.patch

(actually the bootm patch is not really relevant when it comes to ordering).

If anyone can educate me how to get the patches numbered, please
(I have sent this by git send-email 0001... 0002.... etc in one command

Frans.

PS: I once read somewhere that it is also possible to add additional
text in a patch only for the mailing list, so not part of the commit
message.
However, I could not find that info any more. If someone by any chance
knows that please drop me a mail.
FM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] my recent i2c patches
  2010-02-24 19:32 [U-Boot] my recent i2c patches Frans Meulenbroeks
@ 2010-02-24 19:51 ` Eric Bénard
  2010-02-24 20:31 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Bénard @ 2010-02-24 19:51 UTC (permalink / raw)
  To: u-boot

Hi Frans,

Le 24/02/2010 20:32, Frans Meulenbroeks a ?crit :
> If anyone can educate me how to get the patches numbered, please
> (I have sent this by git send-email 0001... 0002.... etc in one command
>
git format-patch -n

        -n, --numbered
            Name output in [PATCH n/m] format, even with a single patch.

> Frans.
>
> PS: I once read somewhere that it is also possible to add additional
> text in a patch only for the mailing list, so not part of the commit
> message.
> However, I could not find that info any more. If someone by any chance
> knows that please drop me a mail.

maybe this option to git format-patch can help you even if that's not 
exactly what you ask here :

        --cover-letter
            In addition to the patches, generate a cover letter file 
containing
            the shortlog and the overall diffstat. You can fill in a
            description in the file before sending it out.

Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] my recent i2c patches
  2010-02-24 19:32 [U-Boot] my recent i2c patches Frans Meulenbroeks
  2010-02-24 19:51 ` Eric Bénard
@ 2010-02-24 20:31 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-02-24 20:31 UTC (permalink / raw)
  To: u-boot

Dear Frans Meulenbroeks,

In message <ac9c93b11002241132j50c1c4a2p5e4407da7f096324@mail.gmail.com> you wrote:
> One word wrt the i2c patches I just mailed.
> It was my impression that git send-email would include the number in
> the patch but as can be seen that was not the case.

Git-send-email does not insert anything, it just sends the emails.
If you want numbered patches, you have to add the numbers when
formatting the patches - i. e. use "git-format-patch -n"

> The patches are to be applied in the following order:
> 0001-cmd_i2c.c-reduced-subaddress-length-to-3-bytes.patch
> 0002-cmd_bootm.c-made-subcommand-array-static.patch
> 0003-cmd_i2c.c-reworked-subcommand-handling.patch
> 0004-cmd_i2c.c-sorted-commands-alphabetically.patch
> 0005-cmd_i2c.c-added-i2c-read-to-memory-function.patch

Thanks.

> PS: I once read somewhere that it is also possible to add additional
> text in a patch only for the mailing list, so not part of the commit
> message.

Indeed. Text below the "---" line is comment.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Good manners are the settled  medium  of  social,  as  specie  is  of
commercial, life; returns are equally expected for both.
           - Lord Chesterfield _Letters to his Son_, 25 December 1753

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-02-24 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 19:32 [U-Boot] my recent i2c patches Frans Meulenbroeks
2010-02-24 19:51 ` Eric Bénard
2010-02-24 20:31 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox