public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] imx27lite board support no longer compile
Date: Thu, 25 Feb 2010 13:17:33 +0100	[thread overview]
Message-ID: <4B866A5D.6040605@denx.de> (raw)
In-Reply-To: <4B8663D3.7040808@denx.de>

Heiko Schocher wrote:
> Hello Stefano,
> 

Hi Heiko,

> your following commit breaks building the imx27lite board
> (and all boards, which uses the ./drivers/net/fec_mxc.c
> I think), because the following function is missing:
> 
> [hs at pollux u-boot]$ grep -lr imx_get_fecclk .
> ./drivers/net/fec_mxc.c
> ./drivers/net/fec_mxc.o
> ./drivers/net/libnet.a
> ./LOG/imx27lite.ERR
> [hs at pollux u-boot]$
> 
> and this function is only used in this driver ...
> 
> ---------------------------------------------------------------
> 
> author	Stefano Babic <sbabic@denx.de>
> commit	4294b2485bf0e8d68c893190a96bb0e7856b12c4
> 
> fec_mxc: add support for MX51 processor
> 
> The patch add support for the Freescale mx51 processor
> 
> to the FEC ethernet driver.
> 
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
> ---------------------------------------------------------------
> 
> ... any ideas?

Yes, at the same time two patches for the fec_imx was sent by me and by
John. John sends to me and to the ML a comment informing that he made
patches to factor a lot of SOC specific, cleaning up code and avoiding
nasty #ifdef.

I see his patch in archive as
http://www.mail-archive.com/u-boot at lists.denx.de/msg27481.html.

I have already used the proposed function, but John's patch is not
already in the mainline - probably it is still in the imx queue. Jason
is working to bring a lot of MX patches in the mainline this week.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-02-25 12:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 11:49 [U-Boot] imx27lite board support no longer compile Heiko Schocher
2010-02-25 12:17 ` Stefano Babic [this message]
2010-03-03  9:56   ` Stefano Babic
2010-03-03 10:13     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B866A5D.6040605@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox