[U-Boot] [PATCH 2/2] arm, i.mx27: add support for magnesium board from LogicPD

Stefano Babic
2010-03-04T11:24:38Z

Heiko Schocher wrote:
> This patch adds support for the magnesium board from LogicPD.
> This board uses i.MX27 SoC and has 8MB NOR flash, 128MB NAND
> flash, FEC ethernet controller integrated into i.MX27.
>

Heiko,

I have only a little comment.

> int checkboard(void)
> {
> +#if defined(CONFIG_MAGNESIUM)
> + printf("LogicPD magnesium\n");

I think we can use puts here instead printf.

> +#else
> printf("LogicPD imx27lite\n");
> +#endif
> return 0;
> }

It is a pity to add a nasty ifdef only to print out the name of the
board. What do you think if we put the board name in the config file
with a CONFIG_ option (the same for imx27lite.h, of course), removing
the #ifdef ?

Best regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================