* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
@ 2010-03-03 9:57 Prafulla Wadaskar
2010-03-04 13:55 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-03-03 9:57 UTC (permalink / raw)
To: u-boot
This patch fixes following build warning
Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
board/keymile/km_arm/kwbimage.cfg | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km_arm/kwbimage.cfg b/board/keymile/km_arm/kwbimage.cfg
index d6edd27..26d6aa0 100644
--- a/board/keymile/km_arm/kwbimage.cfg
+++ b/board/keymile/km_arm/kwbimage.cfg
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register
# bit31-30: 01
DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
- 0x38543000
# bit 3-0: 0 reserved
# bit 4: 0=addr/cmd in smame cycle
# bit 5: 0=clk is driven during self refresh, we don't care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU ODT Control
# bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
DATA 0xFFD01480 0x00000001 # DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
# End of Header extension
DATA 0x0 0x0
--
1.5.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
2010-03-03 9:57 [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning Prafulla Wadaskar
@ 2010-03-04 13:55 ` Tom
2010-03-05 5:14 ` Prafulla Wadaskar
0 siblings, 1 reply; 6+ messages in thread
From: Tom @ 2010-03-04 13:55 UTC (permalink / raw)
To: u-boot
Prafulla Wadaskar wrote:
> This patch fixes following build warning
>
> Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart
>
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> board/keymile/km_arm/kwbimage.cfg | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/board/keymile/km_arm/kwbimage.cfg b/board/keymile/km_arm/kwbimage.cfg
> index d6edd27..26d6aa0 100644
> --- a/board/keymile/km_arm/kwbimage.cfg
> +++ b/board/keymile/km_arm/kwbimage.cfg
> @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register
> # bit31-30: 01
>
> DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
> - 0x38543000
> # bit 3-0: 0 reserved
> # bit 4: 0=addr/cmd in smame cycle
> # bit 5: 0=clk is driven during self refresh, we don't care for APX
> @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU ODT Control
> # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
>
> DATA 0xFFD01480 0x00000001 # DDR Initialization Control
> -#bit0=1, enable DDR init upon this register write
> +# bit0=1, enable DDR init upon this register write
>
> # End of Header extension
> DATA 0x0 0x0
This patch did not fix any of the warnings I saw.
Please recheck.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
2010-03-04 13:55 ` Tom
@ 2010-03-05 5:14 ` Prafulla Wadaskar
2010-03-05 14:18 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-03-05 5:14 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Tom [mailto:Tom.Rix at windriver.com]
> Sent: Thursday, March 04, 2010 7:25 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
> build warning
>
> Prafulla Wadaskar wrote:
> > This patch fixes following build warning
> >
> > Invalid Kwbimage command Type - valid names are: BOOT_FROM,
> NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY,
> DATA, , spi, nand, sata, pex, uart
> >
> > Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> > board/keymile/km_arm/kwbimage.cfg | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/keymile/km_arm/kwbimage.cfg
> b/board/keymile/km_arm/kwbimage.cfg
> > index d6edd27..26d6aa0 100644
> > --- a/board/keymile/km_arm/kwbimage.cfg
> > +++ b/board/keymile/km_arm/kwbimage.cfg
> > @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
> Configuration Register
> > # bit31-30: 01
> >
> > DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
> > - 0x38543000
> > # bit 3-0: 0 reserved
> > # bit 4: 0=addr/cmd in smame cycle
> > # bit 5: 0=clk is driven during self refresh, we don't
> care for APX
> > @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
> ODT Control
> > # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
> >
> > DATA 0xFFD01480 0x00000001 # DDR Initialization Control
> > -#bit0=1, enable DDR init upon this register write
> > +# bit0=1, enable DDR init upon this register write
> >
> > # End of Header extension
> > DATA 0x0 0x0
> This patch did not fix any of the warnings I saw.
> Please recheck.
Hi Tom
I am sorry to say,
it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing.
This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
Regards..
Prafulla . .
> Tom
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
2010-03-05 5:14 ` Prafulla Wadaskar
@ 2010-03-05 14:18 ` Tom
2010-03-06 17:07 ` Prafulla Wadaskar
0 siblings, 1 reply; 6+ messages in thread
From: Tom @ 2010-03-05 14:18 UTC (permalink / raw)
To: u-boot
Prafulla Wadaskar wrote:
>
>
>> -----Original Message-----
>> From: Tom [mailto:Tom.Rix at windriver.com]
>> Sent: Thursday, March 04, 2010 7:25 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
>> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
>> build warning
>>
>> Prafulla Wadaskar wrote:
>>> This patch fixes following build warning
>>>
>>> Invalid Kwbimage command Type - valid names are: BOOT_FROM,
>> NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY,
>> DATA, , spi, nand, sata, pex, uart
>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>> ---
>>> board/keymile/km_arm/kwbimage.cfg | 3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/board/keymile/km_arm/kwbimage.cfg
>> b/board/keymile/km_arm/kwbimage.cfg
>>> index d6edd27..26d6aa0 100644
>>> --- a/board/keymile/km_arm/kwbimage.cfg
>>> +++ b/board/keymile/km_arm/kwbimage.cfg
>>> @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
>> Configuration Register
>>> # bit31-30: 01
>>>
>>> DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
>>> - 0x38543000
>>> # bit 3-0: 0 reserved
>>> # bit 4: 0=addr/cmd in smame cycle
>>> # bit 5: 0=clk is driven during self refresh, we don't
>> care for APX
>>> @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
>> ODT Control
>>> # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
>>>
>>> DATA 0xFFD01480 0x00000001 # DDR Initialization Control
>>> -#bit0=1, enable DDR init upon this register write
>>> +# bit0=1, enable DDR init upon this register write
>>>
>>> # End of Header extension
>>> DATA 0x0 0x0
>> This patch did not fix any of the warnings I saw.
>> Please recheck.
>
> Hi Tom
> I am sorry to say,
> it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing.
> This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
>
Ah!
Ok that helps.
I did not hold up your pull request for this.
Would you like this to go into ARM now?
Tom
> Regards..
> Prafulla . .
>
>> Tom
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
2010-03-05 14:18 ` Tom
@ 2010-03-06 17:07 ` Prafulla Wadaskar
2010-03-06 20:17 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-03-06 17:07 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Tom [mailto:Tom.Rix at windriver.com]
> Sent: Friday, March 05, 2010 7:49 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
> build warning
>
> Prafulla Wadaskar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Tom [mailto:Tom.Rix at windriver.com]
> >> Sent: Thursday, March 04, 2010 7:25 PM
> >> To: Prafulla Wadaskar
> >> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> >> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
> >> build warning
> >>
> >> Prafulla Wadaskar wrote:
> >>> This patch fixes following build warning
> >>>
> >>> Invalid Kwbimage command Type - valid names are: BOOT_FROM,
> >> NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY,
> >> DATA, , spi, nand, sata, pex, uart
> >>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> >>> ---
> >>> board/keymile/km_arm/kwbimage.cfg | 3 +--
> >>> 1 files changed, 1 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/board/keymile/km_arm/kwbimage.cfg
> >> b/board/keymile/km_arm/kwbimage.cfg
> >>> index d6edd27..26d6aa0 100644
> >>> --- a/board/keymile/km_arm/kwbimage.cfg
> >>> +++ b/board/keymile/km_arm/kwbimage.cfg
> >>> @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
> >> Configuration Register
> >>> # bit31-30: 01
> >>>
> >>> DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
> >>> - 0x38543000
> >>> # bit 3-0: 0 reserved
> >>> # bit 4: 0=addr/cmd in smame cycle
> >>> # bit 5: 0=clk is driven during self refresh, we don't
> >> care for APX
> >>> @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
> >> ODT Control
> >>> # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
> >>>
> >>> DATA 0xFFD01480 0x00000001 # DDR Initialization Control
> >>> -#bit0=1, enable DDR init upon this register write
> >>> +# bit0=1, enable DDR init upon this register write
> >>>
> >>> # End of Header extension
> >>> DATA 0x0 0x0
> >> This patch did not fix any of the warnings I saw.
> >> Please recheck.
> >
> > Hi Tom
> > I am sorry to say,
> > it is not build warning but it is runtime stderr generated
> during kwbimage.cfg parsing.
> > This patch removes above mentioned "Invalid Kwbimage
> command Type" error reported by mkimage tool during
> u-boot.kwb target creation for this board.
> >
>
> Ah!
> Ok that helps.
> I did not hold up your pull request for this.
> Would you like this to go into ARM now?
Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request
Regards..
Prafulla . .
>
> Tom
>
> > Regards..
> > Prafulla . .
> >
> >> Tom
> >>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
2010-03-06 17:07 ` Prafulla Wadaskar
@ 2010-03-06 20:17 ` Tom
0 siblings, 0 replies; 6+ messages in thread
From: Tom @ 2010-03-06 20:17 UTC (permalink / raw)
To: u-boot
Prafulla Wadaskar wrote:
>
>
>> -----Original Message-----
>> From: Tom [mailto:Tom.Rix at windriver.com]
>> Sent: Friday, March 05, 2010 7:49 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
>> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
>> build warning
>>
>> Prafulla Wadaskar wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Tom [mailto:Tom.Rix at windriver.com]
>>>> Sent: Thursday, March 04, 2010 7:25 PM
>>>> To: Prafulla Wadaskar
>>>> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
>>>> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
>>>> build warning
>>>>
>>>> Prafulla Wadaskar wrote:
>>>>> This patch fixes following build warning
>>>>>
>>>>> Invalid Kwbimage command Type - valid names are: BOOT_FROM,
>>>> NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY,
>>>> DATA, , spi, nand, sata, pex, uart
>>>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>>>> ---
>>>>> board/keymile/km_arm/kwbimage.cfg | 3 +--
>>>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/board/keymile/km_arm/kwbimage.cfg
>>>> b/board/keymile/km_arm/kwbimage.cfg
>>>>> index d6edd27..26d6aa0 100644
>>>>> --- a/board/keymile/km_arm/kwbimage.cfg
>>>>> +++ b/board/keymile/km_arm/kwbimage.cfg
>>>>> @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
>>>> Configuration Register
>>>>> # bit31-30: 01
>>>>>
>>>>> DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
>>>>> - 0x38543000
>>>>> # bit 3-0: 0 reserved
>>>>> # bit 4: 0=addr/cmd in smame cycle
>>>>> # bit 5: 0=clk is driven during self refresh, we don't
>>>> care for APX
>>>>> @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
>>>> ODT Control
>>>>> # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
>>>>>
>>>>> DATA 0xFFD01480 0x00000001 # DDR Initialization Control
>>>>> -#bit0=1, enable DDR init upon this register write
>>>>> +# bit0=1, enable DDR init upon this register write
>>>>>
>>>>> # End of Header extension
>>>>> DATA 0x0 0x0
>>>> This patch did not fix any of the warnings I saw.
>>>> Please recheck.
>>> Hi Tom
>>> I am sorry to say,
>>> it is not build warning but it is runtime stderr generated
>> during kwbimage.cfg parsing.
>>> This patch removes above mentioned "Invalid Kwbimage
>> command Type" error reported by mkimage tool during
>> u-boot.kwb target creation for this board.
>> Ah!
>> Ok that helps.
>> I did not hold up your pull request for this.
>> Would you like this to go into ARM now?
>
> Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request
>
I have applied it to ARM
Thanks
Tom
> Regards..
> Prafulla . .
>
>> Tom
>>
>>> Regards..
>>> Prafulla . .
>>>
>>>> Tom
>>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-06 20:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 9:57 [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning Prafulla Wadaskar
2010-03-04 13:55 ` Tom
2010-03-05 5:14 ` Prafulla Wadaskar
2010-03-05 14:18 ` Tom
2010-03-06 17:07 ` Prafulla Wadaskar
2010-03-06 20:17 ` Tom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox