From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Thompson <nick.thompson@ge.com>
Date: Wed, 17 Mar 2010 11:10:59 +0000
Subject: [U-Boot] [PATCH v2 1/1] TI: Davinci: NAND Driver Cleanup
In-Reply-To: <1268765506-9957-1-git-send-email-cyril@ti.com>
References: <1268765506-9957-1-git-send-email-cyril@ti.com>
Message-ID: <4BA0B8C3.7060909@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 16/03/10 18:51, Cyril Chemparathy wrote:
>  #define davinci_emif_regs \
> -	((struct davinci_emif_regs *)DAVINCI_ASYNC_EMIF_CNTRL_BASE)
> +       ((struct davinci_emif_regs *)DAVINCI_ASYNC_EMIF_CNTRL_BASE)
> +

I didn't check, but I would assume checkpatch would complain about the
spaces that have crept in here? Can you please restore the original tab?
Mainly this would remove these lines from your patch, which cause a
small confusion as to what exactly has changed and why.

If you haven't already done so, it would be a good idea to run
checkpatch to check for any other formatting violations.

Other than that, the patch looks good to me.

Thanks,
Nick.