From: RONETIX - Asen Dimov <dimov@ronetix.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] add new board pm9g45
Date: Wed, 17 Mar 2010 22:06:19 +0200 [thread overview]
Message-ID: <4BA1363B.7010002@ronetix.at> (raw)
In-Reply-To: <20100316190012.84CA75086C@gemini.denx.de>
Hello Wolfgang,
in the message <20100316190012.84CA75086C@gemini.denx.de> form
16.03.2010 at 09:00 PM
>> +#ifdef CONFIG_LCD
>> +/*
>> + * LCD name TX09D50VM1CCA
>> + */
>> +vidinfo_t panel_info = {
>> + vl_col: 240,
>> + vl_row: 320,
>> + vl_clk: 4965000,
>> + vl_sync: ATMEL_LCDC_INVLINE_NORMAL |
>> + ATMEL_LCDC_INVFRAME_NORMAL,
>> + vl_bpix: 3,
>> + vl_tft: 1,
>> + vl_hsync_len: 5,
>> + vl_left_margin: 1,
>> + vl_right_margin:33,
>> + vl_vsync_len: 1,
>> + vl_upper_margin:1,
>> + vl_lower_margin:0,
>> + mmio: AT91SAM9G45_LCDC_BASE,
>> +};
>>
>
> This information should not be board-specific. The panel information
> is generic and should moved to a separate header file that is not part
> of the board code.
>
>
>
In the boards (at91sam9263ek and at91sam9m10g45ek, and some more
at91sam9 based boards) I am looking at, the panel_info is in the board
specific code.
There are some lcd.c files with panel_info structures:
drivers/video/mx3fb.c, cpu/pxa/pxafb.c and cpu/mpc8xx/lcd.c .
Where should be the proper place for panel_info which is somehow
architecture dependent?
Regards,
Asen
next prev parent reply other threads:[~2010-03-17 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 12:57 [U-Boot] [PATCH] add new board pm9g45 Asen Dimov
2010-03-16 19:00 ` Wolfgang Denk
2010-03-17 20:06 ` RONETIX - Asen Dimov [this message]
2010-03-17 23:00 ` Wolfgang Denk
2010-03-18 6:41 ` Maxim Podbereznyi
2010-03-21 18:57 ` Wolfgang Denk
2010-03-20 19:10 ` Tom
2010-03-21 19:56 ` Wolfgang Denk
2010-03-30 11:55 ` RONETIX - Asen Dimov
-- strict thread matches above, loose matches on Subject: below --
2010-03-16 12:02 Asen Dimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA1363B.7010002@ronetix.at \
--to=dimov@ronetix.at \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox