From mboxrd@z Thu Jan  1 00:00:00 1970
From: RONETIX - Asen Dimov <dimov@ronetix.at>
Date: Wed, 17 Mar 2010 22:06:19 +0200
Subject: [U-Boot] [PATCH] add new board pm9g45
In-Reply-To: <20100316190012.84CA75086C@gemini.denx.de>
References: <1268744233-2497-1-git-send-email-dimov@ronetix.at>
	<20100316190012.84CA75086C@gemini.denx.de>
Message-ID: <4BA1363B.7010002@ronetix.at>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang,

in the message <20100316190012.84CA75086C@gemini.denx.de> form 
16.03.2010 at 09:00 PM
>> +#ifdef CONFIG_LCD
>> +/*
>> + * LCD name TX09D50VM1CCA
>> + */
>> +vidinfo_t panel_info = {
>> +	vl_col:		240,
>> +	vl_row:		320,
>> +	vl_clk:		4965000,
>> +	vl_sync:	ATMEL_LCDC_INVLINE_NORMAL |
>> +			ATMEL_LCDC_INVFRAME_NORMAL,
>> +	vl_bpix:	3,
>> +	vl_tft:		1,
>> +	vl_hsync_len:	5,
>> +	vl_left_margin:	1,
>> +	vl_right_margin:33,
>> +	vl_vsync_len:	1,
>> +	vl_upper_margin:1,
>> +	vl_lower_margin:0,
>> +	mmio:		AT91SAM9G45_LCDC_BASE,
>> +};
>>     
>
> This information should not be board-specific. The panel information
> is generic and should moved to a separate header file that is not part
> of the board code.
>
>
>   
In the boards (at91sam9263ek and at91sam9m10g45ek, and some more 
at91sam9 based boards) I am looking at, the panel_info is in the board 
specific code.
There are some lcd.c files with panel_info structures: 
drivers/video/mx3fb.c, cpu/pxa/pxafb.c and  cpu/mpc8xx/lcd.c .

Where should be the proper place for panel_info which is somehow 
architecture dependent?

Regards,
Asen