public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] fsl_esdhc: Only modify the field we are changing in WML
Date: Sat, 20 Mar 2010 18:59:10 +0100	[thread overview]
Message-ID: <4BA50CEE.1080301@denx.de> (raw)
In-Reply-To: <1269025002-9769-1-git-send-email-galak@kernel.crashing.org>

Kumar Gala wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
> 
> When we set the read or write watermark in WML we should maintain the
> rest of the register as is, rather than using some hard coded value.
> 
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> * This patch supercededs (fsl_esdhc: Only modify WML[WR] field)

Hi,

> +		esdhc_clrsetbits32(&regs->wml, WML_WR_WML_MASK, wml_value << 16);

Line too long.

Tested successfully on mx51evk.

Acked-by: Stefano Babic <sbabic@denx.de>

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-03-20 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 18:56 [U-Boot] [PATCH 3/3] fsl_esdhc: Only modify the field we are changing in WML Kumar Gala
2010-03-20 17:59 ` Stefano Babic [this message]
2010-03-21 17:09   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA50CEE.1080301@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox