public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX51: Moved board specific values in config file
Date: Sat, 20 Mar 2010 19:25:11 -0500	[thread overview]
Message-ID: <4BA56767.3060607@windriver.com> (raw)
In-Reply-To: <1268756600-2244-1-git-send-email-sbabic@denx.de>

Stefano Babic wrote:
> The lowlevel_init file contained some hard-coded values
> to setup the RAM. These board related values are moved into
> the board configuration file.

Why was only one value cleaned up?
Just from the patch, there are at least 4 more.

> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  cpu/arm_cortexa8/mx51/lowlevel_init.S |    5 ++++-
>  include/configs/mx51evk.h             |    3 +++
>  2 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/cpu/arm_cortexa8/mx51/lowlevel_init.S b/cpu/arm_cortexa8/mx51/lowlevel_init.S
> index 31af9e2..1e393bb 100644
> --- a/cpu/arm_cortexa8/mx51/lowlevel_init.S
> +++ b/cpu/arm_cortexa8/mx51/lowlevel_init.S
> @@ -158,6 +158,7 @@
>  	/* Switch peripheral to PLL 3 */
>  	ldr r0, =CCM_BASE_ADDR
>  	ldr r1, =0x000010C0
> + 	orr r1,r1,#CONFIG_SYS_DDR_CLKSEL

git am complains about the leading space
Please remove
>  	str r1, [r0, #CLKCTL_CBCMR]
>  	ldr r1, =0x13239145
>  	str r1, [r0, #CLKCTL_CBCDR]
> @@ -171,6 +172,7 @@
>  	ldr r1, =0x19239145
>  	str r1, [r0, #CLKCTL_CBCDR]
>  	ldr r1, =0x000020C0
> +	orr r1,r1,#CONFIG_SYS_DDR_CLKSEL

This is a noop as it is defined as 0.
Is the value going to change ?

Tom

  reply	other threads:[~2010-03-21  0:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 16:23 [U-Boot] [PATCH] MX51: Moved board specific values in config file Stefano Babic
2010-03-21  0:25 ` Tom [this message]
2010-03-23  8:41   ` Stefano Babic
2010-03-27 20:14     ` Tom
2010-03-28 11:43 ` [U-Boot] [PATCH V2] " Stefano Babic
2010-04-23 10:06   ` Liu Hui-R64343
2010-04-23 12:25     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA56767.3060607@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox