From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init().
Date: Sun, 21 Mar 2010 15:25:46 -0400 [thread overview]
Message-ID: <4BA672BA.3@psyent.com> (raw)
In-Reply-To: <201003211344.29974.vapier@gentoo.org>
Mike Frysinger wrote:
> On Sunday 21 March 2010 13:37:53 Scott McNutt wrote:
>> + WATCHDOG_RESET ();
>> + puts ("Net: ");
>
> considering serial drivers' putc() should be calling watchdog reset, does this
> really make sense here ?
No.
> looks like a wart in a few arches you shouldnt be
> copying over ...
Agreed. Warts can become difficult to remove. ;-)
Regards,
--Scott
prev parent reply other threads:[~2010-03-21 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 17:37 [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init() Scott McNutt
2010-03-21 17:44 ` Mike Frysinger
2010-03-21 19:25 ` Scott McNutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA672BA.3@psyent.com \
--to=smcnutt@psyent.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox