From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott McNutt Date: Sun, 21 Mar 2010 15:25:46 -0400 Subject: [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init(). In-Reply-To: <201003211344.29974.vapier@gentoo.org> References: <1269193073-3709-1-git-send-email-smcnutt@psyent.com> <201003211344.29974.vapier@gentoo.org> Message-ID: <4BA672BA.3@psyent.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Sunday 21 March 2010 13:37:53 Scott McNutt wrote: >> + WATCHDOG_RESET (); >> + puts ("Net: "); > > considering serial drivers' putc() should be calling watchdog reset, does this > really make sense here ? No. > looks like a wart in a few arches you shouldnt be > copying over ... Agreed. Warts can become difficult to remove. ;-) Regards, --Scott