From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Mon, 22 Mar 2010 11:32:06 +0100
Subject: [U-Boot] [PATCH] Add SPI support to mx51evk board
In-Reply-To: <4BA566A5.8040100@windriver.com>
References: <1268756541-2179-1-git-send-email-sbabic@denx.de>
	<4BA566A5.8040100@windriver.com>
Message-ID: <4BA74726.5070803@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tom wrote:
> Stefano Babic wrote:
>> The patch adds SPI devices to the mx51evk board. Two devices
>> are supported: Atmel SPI flash and MC13892 power
>> controller.
> 
> Is Atmel SPI flash already supported?
> It does not look like anything atmel is setup here

No, not yes, only in a future patch set. I must change the comment.

> 
> This is dependent on the
> Added MC13892VK Power Management driver.
> These patches must be combined in a patchset.

Yes, they are. And with the changes in the SPI master (mxc_spi.c). I
will combine all three in a patchset.

>> +
>> +#define REV_ATLAS_LITE_1_0       0x8
>> +#define REV_ATLAS_LITE_1_1       0x9
>> +#define REV_ATLAS_LITE_2_0       0x10
>> +#define REV_ATLAS_LITE_2_1       0x11
> 
> Move these define out of the function.
> Preferablly to an h-file

Ok

>> +
>> +    slave = mc13892_spi_probe();
> 
> The read / write routine bails if slave is invalid.
> It would be better to check earlier here and bail.
> As some of the logic of this function will still run and
> this would leave the hw in a bad state

You are right, I will fix it.

>> +#ifdef CONFIG_MXC_SPI
>> +    setup_iomux_spi(1);
>> +#endif
> 
> In board_late_init, for CONFIG_MXC_SPI, cs=0, here it is cs=1
> Is this correct?
> Please use a if-def here instead of the 0,1
> Maybe CONFIG_MC13892_SPI_PMIC_CS ?

Yes, that is correct. I will change it.

>>  /*
>> + * SPI Configs
>> + * */
> 
> Remove the extra '* '

Ok, thanks.

>> +
>> +#define MAX_SPI_BYTES        (64 * 4)
>> +
> The patch
> 'Added MC13892VK Power Management driver.'
> Depends on this
> Move this #define's to that patch, or an earlier path in the patch set.
> These patches should be bi-sectable

Understood, I will move it.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================