From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Tue, 23 Mar 2010 14:44:28 +0100 Subject: [U-Boot] Environmentvar. "ipaddr" - microblaze In-Reply-To: References: <004d01cac61e$f811b8f0$c801a8c0@xeon> <4BA76EA9.8000400@monstr.eu> <4BA7A7B9.6000103@monstr.eu> Message-ID: <4BA8C5BC.5040309@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Detlev Zundel wrote: > Hi Michal, > >> Detlev Zundel wrote: >>> Hi Michal, >>> >>>> Detlev Zundel wrote: >>>>> Hi Horst, >>>>> >>>>>> in "lib_microblaze/board.c board_init()" the function >>>>>> "env_relocate()" should be called before "getenv_IPaddr()" >>>>>> otherwise there is no chance to save an ip-address in the >>>>>> environment (like in lib_ppc/board.c). >>>> Horst: Give me step-by-step manual how to reach that fault. >>> As long as Horst doesn't answer, I belive he has his environment in SPI >>> flash and was not able to change the "ipaddr" setting used by the >>> network code. >> First off all I am looking forward on that spi driver. > > As he noted in another mail, he used drivers/spi/soft_spi.c with a > little fix successfully. > >>> Now all I can think of is that in lib_microblaze/board.c:144 the call >>> returns the environmetn setting of the compiled in environment rather >>> than the SPI flash saved settings. Thus without doing an explicit >>> "setenv ipaddr" network will always use the compiled in ipaddr. >>> >>> Does that make sense? >> Anyway. I don't need to setup different IP address from command line. > > The environment is one of the most central features of U-Boot. If > setting of "ipaddr" fails to make any impact on tftp transfers, then I > consider it to be broken. I know. I meant that for my work is enough to use only one IP in config file and I don't need to change it on command line. > >> The funny thing is that I have this change in my private repo I sync >> it with ppc some weeks/month ago. >> I will have to invest some time to add all my changes to mainline. >> >> If you want to add only this change, I am ok with it. > > Do you have a timeline on when you will post your changes here for > review? Not yet. I am busy around Linux stuff but I want to do it. Ben: Are you busy? Do you have time to check ll_temac driver and emaclite changes? Cheers, Michal > > Cheers > Detlev > -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian