From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/eth.c: bug-fix
Date: Tue, 23 Mar 2010 10:15:36 -0700 [thread overview]
Message-ID: <4BA8F738.3050806@gmail.com> (raw)
In-Reply-To: <20100321203854.C3C6A4C022@gemini.denx.de>
Wolfgang,
On 3/21/2010 1:38 PM, Wolfgang Denk wrote:
> Dear Ben,
>
> In message<3270DCAC1B1540C7B13D9BC718F543BF@smartbridges.com> Teh Kok How wrote:
>
>> Fixes: Board_eth_init() calls pci_eth_init() (include/netdev.h) and if
>> ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() returns 0.
>> This patch allows cpu_eth_init() to be called.
>>
>>
>> Signed-off-by: Kok How, Teh<k_h_teh@yahoo.com>
>> --- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.000000000 +0800
>> +++ u-boot-2009.11.1.new/net/eth.c 2010-02-12 17:20:32.864273873 +0800
>> @@ -199,7 +199,7 @@
>> #endif
>> /* Try board-specific initialization first. If it fails or isn't
>> * present, try the cpu-specific initialization */
>> - if (board_eth_init(bis)< 0)
>> + if (board_eth_init(bis)<= 0)
>> cpu_eth_init(bis);
>>
>> #if defined(CONFIG_DB64360) || defined(CONFIG_CPCI750)
>>
>>
> Do you have this patch in your queue?
>
>
No, I don't. This patch is wrong, and I believe I already responded
about it. The code does need a subtle clean-up, but I haven't quite
found the time to do it. Hopefully in the next couple of days I'll get
to it.
> Best regards,
>
> Wolfgang Denk
>
regards,
Ben
next prev parent reply other threads:[~2010-03-23 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 4:08 [U-Boot] [PATCH] net/eth.c: bug-fix Teh Kok How
2010-02-12 5:53 ` Ben Warren
2010-02-12 6:57 ` Teh Kok How
2010-02-12 15:19 ` Ben Warren
2010-02-12 9:26 ` Teh Kok How
2010-03-21 20:38 ` Wolfgang Denk
2010-03-23 17:15 ` Ben Warren [this message]
2010-03-23 19:52 ` Wolfgang Denk
2010-03-23 20:23 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA8F738.3050806@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox