From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Tue, 23 Mar 2010 10:15:36 -0700
Subject: [U-Boot] [PATCH] net/eth.c: bug-fix
In-Reply-To: <20100321203854.C3C6A4C022@gemini.denx.de>
References: <07A6D2B84CB942DD8FC96FB7E3CD9CC2@smartbridges.com>
	<3270DCAC1B1540C7B13D9BC718F543BF@smartbridges.com>
	<20100321203854.C3C6A4C022@gemini.denx.de>
Message-ID: <4BA8F738.3050806@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang,
On 3/21/2010 1:38 PM, Wolfgang Denk wrote:
> Dear Ben,
>
> In message<3270DCAC1B1540C7B13D9BC718F543BF@smartbridges.com>  Teh Kok How wrote:
>    
>> Fixes: Board_eth_init() calls pci_eth_init() (include/netdev.h) and if
>> ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() returns 0.
>> This patch allows cpu_eth_init() to be called.
>>
>>
>> Signed-off-by: Kok How, Teh<k_h_teh@yahoo.com>
>> --- u-boot-2009.11.1.orig/net/eth.c     2010-01-25 16:35:12.000000000 +0800
>> +++ u-boot-2009.11.1.new/net/eth.c      2010-02-12 17:20:32.864273873 +0800
>> @@ -199,7 +199,7 @@
>>   #endif
>>          /* Try board-specific initialization first.  If it fails or isn't
>>           * present, try the cpu-specific initialization */
>> -       if (board_eth_init(bis)<  0)
>> +       if (board_eth_init(bis)<= 0)
>>                  cpu_eth_init(bis);
>>
>>   #if defined(CONFIG_DB64360) || defined(CONFIG_CPCI750)
>>
>>      
> Do you have this patch in your queue?
>
>    
No, I don't.  This patch is wrong, and I believe I already responded 
about it.  The code does need a subtle clean-up, but I haven't quite 
found the time to do it.  Hopefully in the next couple of days I'll get 
to it.
> Best regards,
>
> Wolfgang Denk
>    
regards,
Ben