From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi flash: add status polling method for amd flash
Date: Wed, 24 Mar 2010 10:37:02 +0800 [thread overview]
Message-ID: <4BA97ACE.5040003@wytron.com.tw> (raw)
In-Reply-To: <201003231112.50744.sr@denx.de>
On 03/23/2010 06:12 PM, Stefan Roese wrote:
> Hi Thomas,
>
> On Tuesday 23 March 2010 04:24:08 Thomas Chou wrote:
>
>> This patch adds status polling method to offer an alternative to
>> data toggle method for amd flash chips.
>>
>> This patch is needed for nios2 cfi flash interface, where the bus
>> controller performs 4 bytes read cycles for a single byte read
>> instruction. The data toggle method can not detect chip busy
>> status correctly. So we have to poll DQ7, which will be inverted
>> when the chip is busy.
>>
>> This feature is enabled with the config def,
>> CONFIG_SYS_CFI_FLASH_STATUS_POLL
>>
>> Include patch, "drivers/mtd/cfi_flash: precision and underflow
>> problem in tout calculation", submitted by
>> Alessandro Rubini<rub...@gnudd.com>
>> Renato Andreola<renato.andre...@imagos.it>
>>
> Thanks for taking care of this. But we shouldn't really integrate this patch
> into your flash_status_poll() patch. Please re-send this part as a separate
> patch (some subject as original patch with S-o-b line of original author
> please). Thanks again for this.
>
> Please find still more enhancement suggestions below.
>
Hi Stefen,
I resent the tout patch from Renato. I have updated and tested the
status poll patch as you suggested. Any suggestion and improvement is
always welcome.
Cheers,
Thomas
next prev parent reply other threads:[~2010-03-24 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 3:24 [U-Boot] [PATCH] cfi flash: add status polling method for amd flash Thomas Chou
2010-03-23 10:12 ` Stefan Roese
2010-03-24 2:37 ` Thomas Chou [this message]
2010-03-23 10:39 ` [U-Boot] [Nios2-dev] " Michael Schnell
2010-03-24 2:54 ` Thomas Chou
2010-03-24 2:29 ` [U-Boot] [PATCH v4] " Thomas Chou
2010-03-25 8:43 ` Stefan Roese
2010-03-25 11:49 ` Wolfgang Denk
2010-03-26 10:34 ` Stefan Roese
2010-03-25 11:49 ` Wolfgang Denk
2010-03-25 14:23 ` Thomas Chou
2010-03-25 14:38 ` [U-Boot] [PATCH v5] " Thomas Chou
2010-03-26 0:17 ` [U-Boot] [PATCH v6] " Thomas Chou
-- strict thread matches above, loose matches on Subject: below --
2010-03-10 6:05 [U-Boot] [PATCH] " Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA97ACE.5040003@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox