From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Wed, 24 Mar 2010 10:37:02 +0800 Subject: [U-Boot] [PATCH] cfi flash: add status polling method for amd flash In-Reply-To: <201003231112.50744.sr@denx.de> References: <1269314648-6289-1-git-send-email-thomas@wytron.com.tw> <201003231112.50744.sr@denx.de> Message-ID: <4BA97ACE.5040003@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/23/2010 06:12 PM, Stefan Roese wrote: > Hi Thomas, > > On Tuesday 23 March 2010 04:24:08 Thomas Chou wrote: > >> This patch adds status polling method to offer an alternative to >> data toggle method for amd flash chips. >> >> This patch is needed for nios2 cfi flash interface, where the bus >> controller performs 4 bytes read cycles for a single byte read >> instruction. The data toggle method can not detect chip busy >> status correctly. So we have to poll DQ7, which will be inverted >> when the chip is busy. >> >> This feature is enabled with the config def, >> CONFIG_SYS_CFI_FLASH_STATUS_POLL >> >> Include patch, "drivers/mtd/cfi_flash: precision and underflow >> problem in tout calculation", submitted by >> Alessandro Rubini >> Renato Andreola >> > Thanks for taking care of this. But we shouldn't really integrate this patch > into your flash_status_poll() patch. Please re-send this part as a separate > patch (some subject as original patch with S-o-b line of original author > please). Thanks again for this. > > Please find still more enhancement suggestions below. > Hi Stefen, I resent the tout patch from Renato. I have updated and tested the status poll patch as you suggested. Any suggestion and improvement is always welcome. Cheers, Thomas