* [U-Boot] unneeded exported function i2c_mux_add_device
@ 2010-03-24 19:03 Frans Meulenbroeks
2010-03-25 6:39 ` Heiko Schocher
0 siblings, 1 reply; 2+ messages in thread
From: Frans Meulenbroeks @ 2010-03-24 19:03 UTC (permalink / raw)
To: u-boot
Dear list:
While grepping some sources I bumped upon i2c_mux_add_device
This one is implemented in cmd_i2c.c and exported through i2c.h.
However no-one outside cmd_i2c.c is using it:
frans at linux-suse:~/u-boot> grep -r i2c_mux_add_device .
./common/cmd_i2c.c:int i2c_mux_add_device(I2C_MUX_DEVICE *dev)
./common/cmd_i2c.c: i2c_mux_add_device (device);
./include/i2c.h:int i2c_mux_add_device(I2C_MUX_DEVICE *dev);
frans at linux-suse:~/u-boot>
Should we make this function static and remove from the .h file?
Frans
PS: the grep is on an up-to-date next branch
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] unneeded exported function i2c_mux_add_device
2010-03-24 19:03 [U-Boot] unneeded exported function i2c_mux_add_device Frans Meulenbroeks
@ 2010-03-25 6:39 ` Heiko Schocher
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Schocher @ 2010-03-25 6:39 UTC (permalink / raw)
To: u-boot
Hello Frans,
Frans Meulenbroeks wrote:
> While grepping some sources I bumped upon i2c_mux_add_device
> This one is implemented in cmd_i2c.c and exported through i2c.h.
> However no-one outside cmd_i2c.c is using it:
>
> frans at linux-suse:~/u-boot> grep -r i2c_mux_add_device .
> ./common/cmd_i2c.c:int i2c_mux_add_device(I2C_MUX_DEVICE *dev)
> ./common/cmd_i2c.c: i2c_mux_add_device (device);
> ./include/i2c.h:int i2c_mux_add_device(I2C_MUX_DEVICE *dev);
> frans at linux-suse:~/u-boot>
>
> Should we make this function static and remove from the .h file?
Yep, good catch. Please post a patch.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-25 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-24 19:03 [U-Boot] unneeded exported function i2c_mux_add_device Frans Meulenbroeks
2010-03-25 6:39 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox