From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott McNutt Date: Thu, 25 Mar 2010 09:11:26 -0400 Subject: [U-Boot] Rejected: [PATCH v2] nios2: flush data cache after relocating code in start.S In-Reply-To: <1269442321-4229-1-git-send-email-thomas@wytron.com.tw> References: <1269411409-8381-1-git-send-email-thomas@wytron.com.tw> <1269442321-4229-1-git-send-email-thomas@wytron.com.tw> Message-ID: <4BAB60FE.40308@psyent.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Thomas, Patch is reject. > diff --git a/cpu/nios2/start.S b/cpu/nios2/start.S > index 31cd5b0..61784d8 100644 > --- a/cpu/nios2/start.S > +++ b/cpu/nios2/start.S > @@ -98,6 +98,17 @@ _cur: movhi r5, %hi(_cur - _start) > stwio r7, 0(r5) --------^^^^^ The existing code uses stxio instructions, which by their very purpose, bypass the cache. So there's no need to flush the data cache. One could argue that invalidating the _instruction_ cache may be necessary ... but I doubt it, given that first instructions after reset invalidate the entire instruction cache. It would be a defensive nevertheless. Regards, --Scott