[U-Boot] [PATCH 8/8] mop500: add board-specific files

Wolfgang Denk
2010-04-09T22:28:14Z

Dear Rabin VINCENT,

In message <20100408134135.GA4828@bnru02.bnr.st.com> you wrote:
> On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote:
> > Rabin Vincent wrote:
> > > + /* UART2 */
> > > + nmk_gpio_af(29, GPIO_ALT_C);
> > > + nmk_gpio_af(30, GPIO_ALT_C);
> >
> > Change these to immediates to logical #define's
>
> I've changed this in the other places you mentioned, but for these
> GPIOs, I'd prefer to use the pin numbers directly.

Maybe you do, but we don't. Please don't use magic numbers.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Tell the truth and run." - Yugoslav proverb