From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Mon, 29 Mar 2010 07:37:55 -0500
Subject: [U-Boot] [PATCH 1/4] SPEAr : SMI erase and write timeouts
	increased
In-Reply-To: <4BB02551.9010503@st.com>
References: <1269333012-17821-1-git-send-email-vipin.kumar@st.com>
	<1269333012-17821-2-git-send-email-vipin.kumar@st.com>
	<4BAFCF76.8060105@windriver.com> <4BB02551.9010503@st.com>
Message-ID: <4BB09F23.7050707@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Vipin KUMAR wrote:
> On 3/29/2010 3:21 AM, Tom wrote:
>> Vipin KUMAR wrote:
>>> SMI driver fails because of low timeout values. Increasing the erase
>>> and write
>>> timeouts to 3 seconds
>> This is a huge timeout change.
>> 2ms to 3000ms.
>> If something goes wrong, it will seem like the board is hung.
>> Is this ok?
>>
> 
> 2ms timeout itself was a mistake. 3 sec is OK. Offcourse, 3 secs are
> required only when something goes wrong

OK

> 
<snip>
>>> +    } while (timeout--);
>> This changes the function to wait at least 1ms even if timeout == 0.
>> Why was the original logic changed?
>>
> 
> Earlier a value of 2 was reading the status register only once. This I
> felt is more appropriate since the status register is read every ms and
> at least once.

OK

Tom