From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization
Date: Mon, 29 Mar 2010 15:43:50 +0200 [thread overview]
Message-ID: <4BB0AE96.2030008@denx.de> (raw)
In-Reply-To: <1269869743-2093-1-git-send-email-sr@denx.de>
Hello Stefan,
Stefan Roese wrote:
> This patch fixes a problem introduced with patch eb5eb2b0
> [ppc4xx: Cleanup PPC4xx I2C infrastructure]. We need to assign the I2C
> base address to the "i2c" pointer inside of the controller loop.
> Otherwise controller 0 is initialized multiple times instead of
> initializing each I2C controller sequentially.
>
> Tested on Katmai.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> Heiko, I just noticed that this PPC4xx I2C driver is still in the
> cpu/ppc4xx directory. I suggest that we move it into drivers/i2c
> after the next release. Is this ok for you? I can provide a patch
> for this soon.
Yep, that would be the better place for it.
(Did this already in the multibus_v2 branch in
git://git.denx.de/u-boot-i2c.git)
> Please let me know if you see any problems with this patch. I would
> really like to push it into this release, since it really is a bug
> fix.
It looks Ok for me.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2010-03-29 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 13:35 [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1 initialization Stefan Roese
2010-03-29 13:43 ` Heiko Schocher [this message]
2010-03-29 13:49 ` Stefan Roese
2010-03-29 13:57 ` Heiko Schocher
2010-03-29 14:31 ` Stefan Roese
2010-03-29 14:56 ` Heiko Schocher
2010-03-29 15:29 ` Stefan Roese
2010-03-30 11:05 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB0AE96.2030008@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox