From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Mon, 29 Mar 2010 15:43:50 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Fix problem with I2C bus >= 1
	initialization
In-Reply-To: <1269869743-2093-1-git-send-email-sr@denx.de>
References: <1269869743-2093-1-git-send-email-sr@denx.de>
Message-ID: <4BB0AE96.2030008@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stefan,

Stefan Roese wrote:
> This patch fixes a problem introduced with patch eb5eb2b0
> [ppc4xx: Cleanup PPC4xx I2C infrastructure]. We need to assign the I2C
> base address to the "i2c" pointer inside of the controller loop.
> Otherwise controller 0 is initialized multiple times instead of
> initializing each I2C controller sequentially.
> 
> Tested on Katmai.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> Heiko, I just noticed that this PPC4xx I2C driver is still in the
> cpu/ppc4xx directory. I suggest that we move it into drivers/i2c
> after the next release. Is this ok for you? I can provide a patch
> for this soon.

Yep, that would be the better place for it.
(Did this already in the multibus_v2 branch in
 git://git.denx.de/u-boot-i2c.git)

> Please let me know if you see any problems with this patch. I would
> really like to push it into this release, since it really is a bug
> fix.

It looks Ok for me.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany