public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: Set CONFIG_SYS_HZ to 1000 all nios2 boards.
Date: Thu, 01 Apr 2010 07:46:37 -0400	[thread overview]
Message-ID: <4BB4879D.9050306@psyent.com> (raw)
In-Reply-To: <4BB449ED.9080208@monstr.eu>



Michal Simek wrote:
> Scott McNutt wrote:
>>    CONFIG_SYS_HZ was being calculated (incorrectly) in nios2 
>> configuration
>>    headers. Updated comments to accurately describe timebase macros.
>>
>> Signed-off-by: Scott McNutt <smcnutt@psyent.com>
>> ---
>>  include/configs/EP1C20.h  |   14 ++++++++------
>>  include/configs/EP1S10.h  |   14 ++++++++------
>>  include/configs/EP1S40.h  |   14 ++++++++------
>>  include/configs/PCI5441.h |   14 ++++++++------
>>  include/configs/PK1C20.h  |   14 ++++++++------
>>  5 files changed, 40 insertions(+), 30 deletions(-)
> 
> This is the next "nice" patch around altera boards.

Agreed.

> If you do the same 
> changes (because of the same reason) in 5 files it points me that 
> something is wrong.

IMO, it is inefficient, not wrong. But only because each of these
boards worked fine ... until some things changed externally ... that
required a common resolution.

> Please create one generic nios2 file and move there 
> these common macros. Look at ppc405/440 which use that style.

It would indeed be more efficient -- perhaps a common header for
the Altera boards when time permits.

Regards,
--Scott

  reply	other threads:[~2010-04-01 11:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31  1:00 [U-Boot] [PATCH] nios2: Set CONFIG_SYS_HZ to 1000 all nios2 boards Scott McNutt
2010-04-01  7:23 ` Michal Simek
2010-04-01 11:46   ` Scott McNutt [this message]
2010-04-01 16:59     ` Michal Simek
2010-04-02  1:15       ` Scott McNutt
  -- strict thread matches above, loose matches on Subject: below --
2010-03-31  2:09 Scott McNutt
2010-03-31  3:04 ` Thomas Chou
2010-03-31  4:14   ` Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB4879D.9050306@psyent.com \
    --to=smcnutt@psyent.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox