From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Date: Sat, 03 Apr 2010 21:30:43 +0200 Subject: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC In-Reply-To: <4BB78A0B.80905@windriver.com> References: <4BB10FFA.4050403@ahsoftware.de> <1269947827-4752-1-git-send-email-holler@ahsoftware.de> <1269947827-4752-2-git-send-email-holler@ahsoftware.de> <4BB78A0B.80905@windriver.com> Message-ID: <4BB79763.9030306@ahsoftware.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 03.04.2010 20:33, schrieb Tom: > Alexander Holler wrote: > > Change parameter name to something more descriptive. > 'tmp' implies used locally and this value is passed back. > Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ? > Maybe someone should place a README in drivers/rtc which reads "Don't use this stuff as template" as almost every source there uses this tmp. -------------------------- aholler at laptopahvpn ~/Source/u-boot/drivers/rtc $ PAGER= git grep rtc_get bfin_rtc.c:int rtc_get(struct rtc_time *tmp) ds12887.c:int rtc_get (struct rtc_time *tmp) ds1302.c:rtc_get(struct rtc_time *tmp) ds1302.c: printf("ds1302: rtc_get: Clock was halted, clock probably " ds1306.c:int rtc_get (struct rtc_time *tmp) ds1306.c:int rtc_get (struct rtc_time *tmp) ds1307.c:int rtc_get (struct rtc_time *tmp) ds1337.c:int rtc_get (struct rtc_time *tmp) ds1374.c:int rtc_get (struct rtc_time *tm){ ds1556.c:int rtc_get( struct rtc_time *tmp ) ds164x.c:int rtc_get( struct rtc_time *tmp ) ds174x.c:int rtc_get( struct rtc_time *tmp ) ds3231.c:int rtc_get (struct rtc_time *tmp) ftrtc010.c:int rtc_get(struct rtc_time *tmp) isl1208.c:int rtc_get (struct rtc_time *tmp) m41t11.c:int rtc_get (struct rtc_time *tmp) m41t60.c:int rtc_get(struct rtc_time *tmp) m41t62.c:int rtc_get(struct rtc_time *tm) m41t94.c:int rtc_get(struct rtc_time *tm) m48t35ax.c:int rtc_get (struct rtc_time *tmp) max6900.c:int rtc_get (struct rtc_time *tmp) mc13783-rtc.c:int rtc_get(struct rtc_time *rtc) mc146818.c:int rtc_get (struct rtc_time *tmp) mcfrtc.c:int rtc_get(struct rtc_time *tmp) mk48t59.c:int rtc_get (struct rtc_time *tmp) mpc5xxx.c:int rtc_get (struct rtc_time *tmp) mpc8xx.c:int rtc_get (struct rtc_time *tmp) pcf8563.c:int rtc_get (struct rtc_time *tmp) pl031.c:int rtc_get(struct rtc_time *tmp) rs5c372.c:rtc_get (struct rtc_time *tmp) rtc4543.c:int rtc_get(struct rtc_time *tm) rx8025.c:int rtc_get (struct rtc_time *tmp) s3c24x0_rtc.c:int rtc_get(struct rtc_time *tmp) s3c44b0_rtc.c:int rtc_get (struct rtc_time* tm) x1205.c:int rtc_get(struct rtc_time *tm) -------------------------- Happy easter, Alexander