[U-Boot] [PATCH] DM9000: fix build when debugging is enabled

[U-Boot] [PATCH] DM9000: fix build when debugging is enabled

[Mike Frysinger]

From: Brent Kandetzki <BrentK@teleco.com>

The debug code uses the gcc __func__ define, but tries to use it as a
static const string which no longer works.  So treat it like a normal
printf string argument.

Signed-off-by: Brent Kandetzki <BrentK@teleco.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/net/dm9000x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
index 73dd335..a7fef56 100644
--- a/drivers/net/dm9000x.c
+++ b/drivers/net/dm9000x.c
@@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at the moment.
 #define DM9000_DMP_PACKET(func,packet,length)  \
 	do { \
 		int i; 							\
-		printf(func ": length: %d\n", length);			\
+		printf("%s: length: %d\n", func, length);		\
 		for (i = 0; i < length; i++) {				\
 			if (i % 8 == 0)					\
 				printf("\n%s: %02x: ", func, i);	\
-- 
1.7.0.2

[U-Boot] [PATCH] DM9000: fix build when debugging is enabled

[Ben Warren]

Hi Mike,

On 3/24/2010 3:21 PM, Mike Frysinger wrote:
> From: Brent Kandetzki<BrentK@teleco.com>
>
> The debug code uses the gcc __func__ define, but tries to use it as a
> static const string which no longer works.  So treat it like a normal
> printf string argument.
>
> Signed-off-by: Brent Kandetzki<BrentK@teleco.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
>   drivers/net/dm9000x.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> index 73dd335..a7fef56 100644
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at the moment.
>   #define DM9000_DMP_PACKET(func,packet,length)  \
>   	do { \
>   		int i; 							\
> -		printf(func ": length: %d\n", length);			\
> +		printf("%s: length: %d\n", func, length);		\
>   		for (i = 0; i<  length; i++) {				\
>   			if (i % 8 == 0)					\
>   				printf("\n%s: %02x: ", func, i);	\
>    
An identical patch was applied in December (commit 
076cd24cb4278c125c8f36df386852dc0fcfefae).  Am I missing something?

regards,
Ben

[U-Boot] [PATCH] DM9000: fix build when debugging is enabled

[Mike Frysinger]

On Monday 05 April 2010 01:22:39 Ben Warren wrote:
> On 3/24/2010 3:21 PM, Mike Frysinger wrote:
> > From: Brent Kandetzki<BrentK@teleco.com>
> > 
> > The debug code uses the gcc __func__ define, but tries to use it as a
> > static const string which no longer works.  So treat it like a normal
> > printf string argument.
> > 
> > Signed-off-by: Brent Kandetzki<BrentK@teleco.com>
> > Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> > ---
> > 
> >   drivers/net/dm9000x.c |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> > index 73dd335..a7fef56 100644
> > --- a/drivers/net/dm9000x.c
> > +++ b/drivers/net/dm9000x.c
> > @@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at
> > the moment.
> > 
> >   #define DM9000_DMP_PACKET(func,packet,length)  \
> >   
> >   	do { \
> >   	
> >   		int i; 							\
> > 
> > -		printf(func ": length: %d\n", length);			\
> > +		printf("%s: length: %d\n", func, length);		\
> > 
> >   		for (i = 0; i<  length; i++) {				\
> >   		
> >   			if (i % 8 == 0)					\
> >   			
> >   				printf("\n%s: %02x: ", func, i);	\
> 
> An identical patch was applied in December (commit
> 076cd24cb4278c125c8f36df386852dc0fcfefae).  Am I missing something?

nope ... i was looking at the 2009.11 release apparently
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100406/ccbaba3a/attachment.pgp