From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/28] nios2: add nios2-generic board
Date: Sun, 04 Apr 2010 22:36:41 -0700 [thread overview]
Message-ID: <4BB976E9.9050804@gmail.com> (raw)
In-Reply-To: <1268984633-12224-2-git-send-email-thomas@wytron.com.tw>
Hi Thomas,
On 3/19/2010 12:43 AM, Thomas Chou wrote:
> This is a generic approach to port u-boot for nios2 boards.
> It uses a new set of device drivers, such as the cfi flash, spi
> lash, nand flash and new ethernet drivers.
>
>
<snip>
> +#ifdef CONFIG_CMD_NET
> +int board_eth_init(bd_t *bis)
> +{
> + int rc = 0;
> +#ifdef CONFIG_SMC91111
> + rc = smc91111_initialize(bis, CONFIG_SMC91111_BASE);
> +#endif
> +
> +#ifdef CONFIG_DRIVER_DM9000
> + rc = dm9000_initialize(bis);
> +#endif
> +
> +#ifdef CONFIG_ALTERA_TSE
> + altera_tse_init(bis, CONFIG_SYS_NUM_TSE_MACS);
> +#endif
> +
> +#ifdef CONFIG_ETHOC
> + rc = ethoc_initialize(bis, CONFIG_SYS_ETHOC_BASE);
> +#endif
> + return rc;
> +}
>
Please clean up the return code handling. The drivers are not mutually
exclusive.
<snip>
> +
> +#define CONFIG_ETHADDR 08:00:3e:26:0a:5b
> +#define CONFIG_NETMASK 255.255.255.0
> +#define CONFIG_IPADDR 192.168.2.21
> +#define CONFIG_SERVERIP 192.168.2.16
> +
>
Please remove these definitions
regards,
Ben
next prev parent reply other threads:[~2010-04-05 5:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 7:43 [U-Boot] [PATCH 00/28] u-boot next: a generic approach for nios2 arch Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 01/28] nios2: add nios2-generic board Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 02/28] cfi flash: add status polling method for amd flash Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 03/28] serial: move altera uart driver to drivers/serial Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 04/28] serial: move altera jtaguart " Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 05/28] serial: move yanu " Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 06/28] spi: add altera spi controller support Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 07/28] net: add opencore 10/100 ethernet mac support Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 08/28] net: add altera triple speeds " Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 09/28] nios2: change asm-nios2/io.h to compatible with nios2 linux Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 10/28] nios2: add asm-nios2/errno.h Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 11/28] nios2: add local_irq_enable/disable to asm-nios2/system.h Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 12/28] nios2: use bitops from linux-2.6 asm-generic Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 13/28] nios2: fix __fswab64 link error with asm-nios2/byteorder.h Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 14/28] nios2: add dma_alloc_coherent with asm-nios2/dma-mapping.h Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 15/28] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 16/28] nios2: move timer handler from interrupt.c to timer.c Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 17/28] nios2: define text_base in start.S for linker script Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 18/28] nios2: pass command line and initrd to linux Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 19/28] nios2: board init for eth, no flash, nand and mmc Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 20/28] nios2: fix writel in board/altera/common/epled.c Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 21/28] nios2: add cf ide init and reset handler Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 22/28] nios2: add gpio led driver Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 23/28] nios2: convert ep1c20 board to use cfi flash and spi flash Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 24/28] nios2: convert ep1s10 board to use cfi flash Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 25/28] nios2: convert ep1s40 " Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 26/28] nios2: convert pci5441 " Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 27/28] nios2: convert pk1c20 board to use cfi flash and spi flash Thomas Chou
2010-03-19 7:43 ` [U-Boot] [PATCH 28/28] nios2: add struct stat support in linux/stat.h Thomas Chou
2010-04-05 5:36 ` Ben Warren [this message]
2010-04-07 3:19 ` [U-Boot] [PATCH 01/28] nios2: add nios2-generic board Thomas Chou
2010-04-07 17:23 ` Ben Warren
2010-03-19 14:41 ` [U-Boot] [PATCH 00/28] u-boot next: a generic approach for nios2 arch Thomas Chou
2010-03-19 14:55 ` Peter Tyser
2010-03-19 15:23 ` Thomas Chou
2010-03-19 18:40 ` Wolfgang Denk
2010-03-19 18:56 ` Scott Wood
2010-03-19 19:59 ` Wolfgang Denk
2010-03-19 21:07 ` Peter Tyser
2010-03-21 20:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB976E9.9050804@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox