public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check.
Date: Mon, 05 Apr 2010 07:50:17 -0500	[thread overview]
Message-ID: <4BB9DC89.7060005@windriver.com> (raw)
In-Reply-To: <1270042735-26032-1-git-send-email-dzu@denx.de>

Detlev Zundel wrote:
> pci_eth_init() is already conditional to CONFIG_PCI so not every caller
> needs to have conditionals.
> 
> This is the only place in the current code base where such a check is
> still at the calling site.

Applied to arm/master
Thanks
Tom

> 
> Signed-off-by: Detlev Zundel <dzu@denx.de>
> CC: Ben Warren <biggerbadderben@gmail.com>
> CC: Peter Pearse <peter.pearse@arm.com>
> ---
>  board/armltd/integrator/integrator.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
> index 518944e..9bb56b5 100644
> --- a/board/armltd/integrator/integrator.c
> +++ b/board/armltd/integrator/integrator.c
> @@ -132,9 +132,7 @@ int board_eth_init(bd_t *bis)
>  #ifdef CONFIG_SMC91111
>  	rc = smc91111_initialize(0, CONFIG_SMC91111_BASE);
>  #endif
> -#ifdef CONFIG_PCI
>  	rc += pci_eth_init(bis);
> -#endif
>  	return rc;
>  }
>  #endif

      reply	other threads:[~2010-04-05 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 13:38 [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check Detlev Zundel
2010-04-05 12:50 ` Tom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB9DC89.7060005@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox