* [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check.
@ 2010-03-31 13:38 Detlev Zundel
2010-04-05 12:50 ` Tom
0 siblings, 1 reply; 2+ messages in thread
From: Detlev Zundel @ 2010-03-31 13:38 UTC (permalink / raw)
To: u-boot
pci_eth_init() is already conditional to CONFIG_PCI so not every caller
needs to have conditionals.
This is the only place in the current code base where such a check is
still at the calling site.
Signed-off-by: Detlev Zundel <dzu@denx.de>
CC: Ben Warren <biggerbadderben@gmail.com>
CC: Peter Pearse <peter.pearse@arm.com>
---
board/armltd/integrator/integrator.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
index 518944e..9bb56b5 100644
--- a/board/armltd/integrator/integrator.c
+++ b/board/armltd/integrator/integrator.c
@@ -132,9 +132,7 @@ int board_eth_init(bd_t *bis)
#ifdef CONFIG_SMC91111
rc = smc91111_initialize(0, CONFIG_SMC91111_BASE);
#endif
-#ifdef CONFIG_PCI
rc += pci_eth_init(bis);
-#endif
return rc;
}
#endif
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check.
2010-03-31 13:38 [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check Detlev Zundel
@ 2010-04-05 12:50 ` Tom
0 siblings, 0 replies; 2+ messages in thread
From: Tom @ 2010-04-05 12:50 UTC (permalink / raw)
To: u-boot
Detlev Zundel wrote:
> pci_eth_init() is already conditional to CONFIG_PCI so not every caller
> needs to have conditionals.
>
> This is the only place in the current code base where such a check is
> still at the calling site.
Applied to arm/master
Thanks
Tom
>
> Signed-off-by: Detlev Zundel <dzu@denx.de>
> CC: Ben Warren <biggerbadderben@gmail.com>
> CC: Peter Pearse <peter.pearse@arm.com>
> ---
> board/armltd/integrator/integrator.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
> index 518944e..9bb56b5 100644
> --- a/board/armltd/integrator/integrator.c
> +++ b/board/armltd/integrator/integrator.c
> @@ -132,9 +132,7 @@ int board_eth_init(bd_t *bis)
> #ifdef CONFIG_SMC91111
> rc = smc91111_initialize(0, CONFIG_SMC91111_BASE);
> #endif
> -#ifdef CONFIG_PCI
> rc += pci_eth_init(bis);
> -#endif
> return rc;
> }
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-05 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-31 13:38 [U-Boot] [PATCH] arm/integrator: Remove unneccessary CONFIG_PCI check Detlev Zundel
2010-04-05 12:50 ` Tom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox