From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC
Date: Mon, 05 Apr 2010 08:19:38 -0500 [thread overview]
Message-ID: <4BB9E36A.1020402@windriver.com> (raw)
In-Reply-To: <4BB79763.9030306@ahsoftware.de>
Alexander Holler wrote:
> Am 03.04.2010 20:33, schrieb Tom:
>> Alexander Holler wrote:
>>
>> Change parameter name to something more descriptive.
>> 'tmp' implies used locally and this value is passed back.
>> Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ?
>>
>
> Maybe someone should place a README in drivers/rtc which reads "Don't
> use this stuff as template" as almost every source there uses this tmp.
>
The important change for this patch is to move to the new Soc access.
The other uses of rtc_time *tmp, I would also consider as problems.
Changing tmp -> tm for your patch is an improvement.
This is good time to make it.
Tom
next prev parent reply other threads:[~2010-04-05 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 19:39 [U-Boot] [PATCH 0/2] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-03-29 19:39 ` [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR Alexander Holler
2010-03-29 19:39 ` [U-Boot] [PATCH 2/2] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-03-29 20:39 ` Alexander Holler
2010-03-30 11:17 ` [U-Boot] [PATCH 0/1] at91samm9x: fix for the rtc-driver Alexander Holler
2010-03-30 11:17 ` [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-04-03 18:33 ` Tom
2010-04-03 19:30 ` Alexander Holler
2010-04-05 13:19 ` Tom [this message]
2010-04-03 18:36 ` [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR Tom
2010-04-03 20:41 ` Alexander Holler
2010-04-05 13:29 ` Tom
2010-04-11 17:23 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB9E36A.1020402@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox