From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Mon, 05 Apr 2010 08:19:38 -0500
Subject: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT
 as	RTC
In-Reply-To: <4BB79763.9030306@ahsoftware.de>
References: <4BB10FFA.4050403@ahsoftware.de>	<1269947827-4752-1-git-send-email-holler@ahsoftware.de>
	<1269947827-4752-2-git-send-email-holler@ahsoftware.de>
	<4BB78A0B.80905@windriver.com> <4BB79763.9030306@ahsoftware.de>
Message-ID: <4BB9E36A.1020402@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Alexander Holler wrote:
> Am 03.04.2010 20:33, schrieb Tom:
>> Alexander Holler wrote:
>>
>> Change parameter name to something more descriptive.
>> 'tmp' implies used locally and this value is passed back.
>> Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ?
>>
> 
> Maybe someone should place a README in drivers/rtc which reads "Don't 
> use this stuff as template" as almost every source there uses this tmp.
> 

The important change for this patch is to move to the new Soc access.

The other uses of rtc_time *tmp, I would also consider as problems.
Changing tmp -> tm for your patch is an improvement.
This is good time to make it.

Tom