public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR
Date: Mon, 05 Apr 2010 08:29:31 -0500	[thread overview]
Message-ID: <4BB9E5BB.8070203@windriver.com> (raw)
In-Reply-To: <4BB7A817.9060401@ahsoftware.de>

Alexander Holler wrote:
> Am 03.04.2010 20:36, schrieb Tom:
>> Alexander Holler wrote:
>>> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
>>> ---
>>> include/asm-arm/arch-at91/at91sam9260.h | 2 ++
>>> include/asm-arm/arch-at91/at91sam9261.h | 2 ++
>>> include/asm-arm/arch-at91/at91sam9263.h | 3 +++
>>> 3 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>
>> Ack
>> This change is fine.
>> Please include this with the changes to the rtc driver in patch 2/2
>> In general, include all the patches in a patchset when you make a change
>> to any one of them.
> 
> This two patches are unrelated. This patch just makes incomplete headers 
> more complete. If something else would use those two defines and anyone 
> would revert the patch for rtc-driver the revert would eleminate the 
> defines too.
> 

Patch 2/2 depends on patch 1/2.

 From 2/2

+#define gpbr_readl() \
+	readl(AT91_GPBR_BASE + 4 * CONFIG_RTC_AT91SAM9_GPBR)
+#define gpbr_writel(val) \
+	writel((val), AT91_GPBR_BASE + 4 * CONFIG_RTC_AT91SAM9_GPBR)

 From 1/2

--- a/include/asm-arm/arch-at91/at91sam9260.h
+++ b/include/asm-arm/arch-at91/at91sam9260.h
@@ -56,8 +56,10 @@
  #define AT91_PIO_BASE		0xfffff400
  #define AT91_PMC_BASE		0xfffffc00
  #define AT91_RSTC_BASE		0xfffffd00
+#define AT91_RTT_BASE		0xfffffd20
  #define AT91_PIT_BASE		0xfffffd30
  #define AT91_WDT_BASE		0xfffffd40
+#define AT91_GPR_BASE		0xfffffd50

 From inspection, at least some boards would have an error if 1/2 was
not applied before 2/2.

1/2 is ok by itself.
I will go ahead and apply this patch.

Thanks
Tom

  reply	other threads:[~2010-04-05 13:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 19:39 [U-Boot] [PATCH 0/2] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-03-29 19:39 ` [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR Alexander Holler
2010-03-29 19:39   ` [U-Boot] [PATCH 2/2] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-03-29 20:39     ` Alexander Holler
2010-03-30 11:17       ` [U-Boot] [PATCH 0/1] at91samm9x: fix for the rtc-driver Alexander Holler
2010-03-30 11:17         ` [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC Alexander Holler
2010-04-03 18:33           ` Tom
2010-04-03 19:30             ` Alexander Holler
2010-04-05 13:19               ` Tom
2010-04-03 18:36   ` [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR Tom
2010-04-03 20:41     ` Alexander Holler
2010-04-05 13:29       ` Tom [this message]
2010-04-11 17:23   ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB9E5BB.8070203@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox