public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] FIX: watchdog timeout, while waiting for input
@ 2010-04-09 17:02 Jens Scharsig
  2010-04-10 21:31 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Scharsig @ 2010-04-09 17:02 UTC (permalink / raw)
  To: u-boot

* add WATCHDOG_RESET to !tstc() loops
* prevents watchdog timeout, while waiting for input, 
  if CONFIG_BOOT_RETRY_TIME or CONFIG_SHOW_ACTIVITY defined


Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
 common/main.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/common/main.c b/common/main.c
index 3949a5b..f7e7c1c 100644
--- a/common/main.c
+++ b/common/main.c
@@ -730,6 +730,7 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len)
 		while (!tstc()) {	/* while no incoming data */
 			if (retry_time >= 0 && get_ticks() > endtime)
 				return (-2);	/* timed out */
+			WATCHDOG_RESET();
 		}
 #endif
 
@@ -997,6 +998,7 @@ int readline_into_buffer (const char *const prompt, char * buffer)
 		while (!tstc()) {	/* while no incoming data */
 			if (retry_time >= 0 && get_ticks() > endtime)
 				return (-2);	/* timed out */
+			WATCHDOG_RESET();
 		}
 #endif
 		WATCHDOG_RESET();		/* Trigger watchdog, if needed */
@@ -1005,6 +1007,7 @@ int readline_into_buffer (const char *const prompt, char * buffer)
 		while (!tstc()) {
 			extern void show_activity(int arg);
 			show_activity(0);
+			WATCHDOG_RESET();
 		}
 #endif
 		c = getc();
-- 
1.6.0.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] FIX: watchdog timeout, while waiting for input
  2010-04-09 17:02 [U-Boot] [PATCH] FIX: watchdog timeout, while waiting for input Jens Scharsig
@ 2010-04-10 21:31 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2010-04-10 21:31 UTC (permalink / raw)
  To: u-boot

Dear Jens Scharsig,

In message <4BBF5DAE.9000608@scharsoft.de> you wrote:
> * add WATCHDOG_RESET to !tstc() loops
> * prevents watchdog timeout, while waiting for input, 
>   if CONFIG_BOOT_RETRY_TIME or CONFIG_SHOW_ACTIVITY defined
> 
> 
> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
> ---
>  common/main.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Experience is what causes a person to make new  mistakes  instead  of
old ones.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-10 21:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-09 17:02 [U-Boot] [PATCH] FIX: watchdog timeout, while waiting for input Jens Scharsig
2010-04-10 21:31 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox