From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 09/13] arm: add Cortex A9 support
Date: Sun, 11 Apr 2010 15:45:41 -0500 [thread overview]
Message-ID: <4BC234F5.4010906@windriver.com> (raw)
In-Reply-To: <g2nc928c27e1004100954tc384ae9dg6109fed55df18262@mail.gmail.com>
Rabin Vincent wrote:
> On Fri, Apr 9, 2010 at 6:57 PM, Vaibhav Bedia <vaibhav.bedia@gmail.com> wrote:
>> As all Cortex processors implement the ARMv7 architecture a better grouping
>> IMHO would be cpu/cortex/a8 and cpu/cortex/a9. The common stuff can be under
>> cpu/cortex/.
>
> Perhaps Tom can clarify if he's OK with this, since he wanted a separate
> cpu/cortex_a9 directory to be created (The first version of my patch series
> just put the Ux500 code into cortex_a8).
>
> The only potential problem I see with this is that some fixups will have to be
> done in the Makefiles for lib$(CPU).a generation since $(CPU) would have a
> slash in it after this. This could be avoided by keeping the SOC directories
> for all Cortexes in cpu/arm_cortex itself instead of a8 and a9 subdirectories.
>
> Rabin
The change the Nishanth proposed is better.
I am ok with this change.
My concern with the original Ux500 code was not to include a9 in a8.
As this would in the long run make for less readable and less maintainable code.
The new change would mean less copying of files but more reordering.
I would suggest that 'fix me' warnings would be added to the a8 boards to defer
the reordering. The reordering need not all in the ux500 patchset. If you want
to take up all the reordering, that is fine too.
Tom
next prev parent reply other threads:[~2010-04-11 20:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 13:43 [U-Boot] [PATCHv2 00/13] ST-Ericsson Ux500 support Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 01/13] Nomadik: move nomadik.h to asm/arch/nhk8815.h Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 02/13] Nomadik: timer: push down single-use macros Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 03/13] Nomadik: timer: remove header and use C structs Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 04/13] Nomadik: move timer code to drivers/misc Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 05/13] Nomadik: move gpio driver to drivers/gpio Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 06/13] nomadik-gpio: check for invalid gpio numbers Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 07/13] nomadik-gpio: get base address from platform code Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 08/13] nomadik-mtu: support configurable clock rates Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 09/13] arm: add Cortex A9 support Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 10/13] ARM Cortex A9: ifdef code calling lowlevel init Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 11/13] ux500: add SoC-specific code Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 12/13] pl01x: add support for Ux500 variant of pl011 Rabin Vincent
2010-04-08 13:43 ` [U-Boot] [PATCHv2 13/13] mop500: add board-specific files Rabin Vincent
2010-04-09 23:04 ` [U-Boot] [PATCHv2 12/13] pl01x: add support for Ux500 variant of pl011 Wolfgang Denk
2010-04-09 11:29 ` [U-Boot] [PATCHv2 09/13] arm: add Cortex A9 support Nishanth Menon
2010-04-09 13:27 ` Vaibhav Bedia
2010-04-09 23:06 ` Wolfgang Denk
2010-04-10 0:22 ` Nishanth Menon
2010-04-10 16:54 ` Rabin Vincent
2010-04-11 20:45 ` Tom [this message]
2010-04-20 12:16 ` Rabin VINCENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC234F5.4010906@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox