[U-Boot] [PATCHv2 09/13] arm: add Cortex A9 support

Vaibhav Bedia
2010-04-09T13:27:16Z

On Fri, Apr 9, 2010 at 4:59 PM, Nishanth Menon <menon.nishanth@gmail.com>wrote:

> On 04/08/2010 08:43 AM, Rabin Vincent wrote:
> > Add Cortex A9 support by copying the code for Cortex A8. The only
> > change is a removal of some OMAP3 specific code.
> Thanks :), I was hoping to help in the near future by adding OMAP4 code
> in cortex a9.. ;)
>
> >
> > Acked-by: Michael Brandt<michael.brandt@stericsson.com>
> > Signed-off-by: Rabin Vincent<rabin.vincent@stericsson.com>
> > ---
> > cpu/{arm_cortexa8 => arm_cortexa9}/Makefile | 0
> > cpu/{arm_cortexa8 => arm_cortexa9}/config.mk | 0
> > cpu/{arm_cortexa8 => arm_cortexa9}/cpu.c | 0
> > cpu/{arm_cortexa8 => arm_cortexa9}/start.S | 26
> +------------------------
> > cpu/{arm_cortexa8 => arm_cortexa9}/u-boot.lds | 2 +-
> > 5 files changed, 2 insertions(+), 26 deletions(-)
> > copy cpu/{arm_cortexa8 => arm_cortexa9}/Makefile (100%)
> > copy cpu/{arm_cortexa8 => arm_cortexa9}/config.mk (100%)
> > copy cpu/{arm_cortexa8 => arm_cortexa9}/cpu.c (100%)
> > copy cpu/{arm_cortexa8 => arm_cortexa9}/start.S (91%)
> > copy cpu/{arm_cortexa8 => arm_cortexa9}/u-boot.lds (97%)
>
> looking at the % of reuse.. for a9, cant we avoid a copy? since a9 and
> a8 are both v7 instruction set anyways,
>
> how about cpu/arm_cortexa8,a9 etc replaced by cpu/armv7 and have cortex
> and soc specific code within it?
>
> Making the folders based on ISA version would be confusing as the other ARM
cores are not grouped that way.
As all Cortex processors implement the ARMv7 architecture a better grouping
IMHO would be cpu/cortex/a8 and cpu/cortex/a9. The common stuff can be under
cpu/cortex/.

> option a:
> cpu/armv7/
> common code.[cS..]
> /cortex_a8/
> /cortex_a9/
> soc specific code:
> option 1:
> cpu/armv7/cortex_a[89]/soc
> or option 2:
> cpu/armv7/soc
>
> option b:
> cpu/armv7_common/
> cpu/cortex_a8/
> cpu/cortex_a9/
>
> (socs thier usual place cpu/cortex_a[89]/socx
> option c:
> cpu/armv7
> cpu/armv7/soc1
> cpu/armv7/soc2
> etc..
> v7 has both a8 and a9 codebases..
>
> Regards,
> Nishanth Menon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

--
Regards,
Vaibhav