public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h
@ 2010-03-26 11:18 Thomas Chou
  2010-03-26 22:31 ` [U-Boot] [PATCH v2] " Thomas Chou
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Thomas Chou @ 2010-03-26 11:18 UTC (permalink / raw)
  To: u-boot

This patch adds driver for a trivial gpio core, which is described
in http://nioswiki.com/GPIO.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
 include/asm-nios2/gpio.h |   42 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 include/asm-nios2/gpio.h

diff --git a/include/asm-nios2/gpio.h b/include/asm-nios2/gpio.h
new file mode 100644
index 0000000..ef8c9fd
--- /dev/null
+++ b/include/asm-nios2/gpio.h
@@ -0,0 +1,42 @@
+/*
+ * nios2 gpio driver
+ *
+ * This gpio core is described in http://nioswiki.com/GPIO
+ * bit[0] data
+ * bit[1] output enable
+ *
+ * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _ASM_NIOS2_GPIO_H_
+#define _ASM_NIOS2_GPIO_H_ 1
+
+#include <asm/io.h>
+
+static inline int gpio_direction_input(unsigned pin)
+{
+	writel(1, CONFIG_SYS_GPIO_BASE + ((pin) << 2));
+	return 0;
+}
+
+static inline int gpio_direction_output(unsigned pin, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((pin) << 2));
+	return 0;
+}
+
+static inline int gpio_get_value(unsigned pin)
+{
+	return readl(CONFIG_SYS_GPIO_BASE + ((pin) << 2));
+}
+
+static inline void gpio_set_value(unsigned pin, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((pin) << 2));
+}
+
+#endif /* _ASM_NIOS2_GPIO_H_ */
-- 
1.6.6.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v2] nios2: add gpio support with asm-nios2/gpio.h
  2010-03-26 11:18 [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
@ 2010-03-26 22:31 ` Thomas Chou
  2010-04-17 12:16 ` [U-Boot] [PATCH v3] nios2: add gpio support Thomas Chou
  2010-04-17 15:02 ` [U-Boot] [PATCH v4] " Thomas Chou
  2 siblings, 0 replies; 6+ messages in thread
From: Thomas Chou @ 2010-03-26 22:31 UTC (permalink / raw)
  To: u-boot

This patch adds driver for a trivial gpio core, which is described
in http://nioswiki.com/GPIO.

When CONFIG_SYS_GPIO_BASE is not defined, board may provide
its own driver.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
 include/asm-nios2/gpio.h |   52 ++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)
 create mode 100644 include/asm-nios2/gpio.h

diff --git a/include/asm-nios2/gpio.h b/include/asm-nios2/gpio.h
new file mode 100644
index 0000000..cd2df7d
--- /dev/null
+++ b/include/asm-nios2/gpio.h
@@ -0,0 +1,52 @@
+/*
+ * nios2 gpio driver
+ *
+ * This gpio core is described in http://nioswiki.com/GPIO
+ * bit[0] data
+ * bit[1] output enable
+ *
+ * when CONFIG_SYS_GPIO_BASE is not defined, board may provide
+ * its own driver.
+ *
+ * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _ASM_NIOS2_GPIO_H_
+#define _ASM_NIOS2_GPIO_H_ 1
+
+#ifdef CONFIG_SYS_GPIO_BASE
+#include <asm/io.h>
+
+static inline int gpio_direction_input(unsigned gpio)
+{
+	writel(1, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+	return 0;
+}
+
+static inline int gpio_direction_output(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+	return 0;
+}
+
+static inline int gpio_get_value(unsigned gpio)
+{
+	return readl(CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+}
+
+static inline void gpio_set_value(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+}
+#else
+extern int gpio_direction_input(unsigned gpio);
+extern int gpio_direction_output(unsigned gpio, int value);
+extern int gpio_get_value(unsigned gpio);
+extern void gpio_set_value(unsigned gpio, int value);
+#endif /* CONFIG_SYS_GPIO_BASE */
+
+#endif /* _ASM_NIOS2_GPIO_H_ */
-- 
1.6.6.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v3] nios2: add gpio support
  2010-03-26 11:18 [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
  2010-03-26 22:31 ` [U-Boot] [PATCH v2] " Thomas Chou
@ 2010-04-17 12:16 ` Thomas Chou
  2010-04-17 14:18   ` Sergei Shtylyov
  2010-04-17 15:02 ` [U-Boot] [PATCH v4] " Thomas Chou
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Chou @ 2010-04-17 12:16 UTC (permalink / raw)
  To: u-boot

This patch adds driver for a trivial gpio core, which is described
in http://nioswiki.com/GPIO.

When CONFIG_SYS_GPIO_BASE is not defined, board may provide
its own driver.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
arch dir reorganized.

 arch/nios2/include/asm/gpio.h |   52 +++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)
 create mode 100644 arch/nios2/include/asm/gpio.h

diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h
new file mode 100644
index 0000000..cd2df7d
--- /dev/null
+++ b/arch/nios2/include/asm/gpio.h
@@ -0,0 +1,52 @@
+/*
+ * nios2 gpio driver
+ *
+ * This gpio core is described in http://nioswiki.com/GPIO
+ * bit[0] data
+ * bit[1] output enable
+ *
+ * when CONFIG_SYS_GPIO_BASE is not defined, board may provide
+ * its own driver.
+ *
+ * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _ASM_NIOS2_GPIO_H_
+#define _ASM_NIOS2_GPIO_H_ 1
+
+#ifdef CONFIG_SYS_GPIO_BASE
+#include <asm/io.h>
+
+static inline int gpio_direction_input(unsigned gpio)
+{
+	writel(1, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+	return 0;
+}
+
+static inline int gpio_direction_output(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+	return 0;
+}
+
+static inline int gpio_get_value(unsigned gpio)
+{
+	return readl(CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+}
+
+static inline void gpio_set_value(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
+}
+#else
+extern int gpio_direction_input(unsigned gpio);
+extern int gpio_direction_output(unsigned gpio, int value);
+extern int gpio_get_value(unsigned gpio);
+extern void gpio_set_value(unsigned gpio, int value);
+#endif /* CONFIG_SYS_GPIO_BASE */
+
+#endif /* _ASM_NIOS2_GPIO_H_ */
-- 
1.6.6.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v3] nios2: add gpio support
  2010-04-17 12:16 ` [U-Boot] [PATCH v3] nios2: add gpio support Thomas Chou
@ 2010-04-17 14:18   ` Sergei Shtylyov
  2010-04-17 14:50     ` Thomas Chou
  0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2010-04-17 14:18 UTC (permalink / raw)
  To: u-boot

Hello.

Thomas Chou wrote:

> This patch adds driver for a trivial gpio core, which is described
> in http://nioswiki.com/GPIO.
>
> When CONFIG_SYS_GPIO_BASE is not defined, board may provide
> its own driver.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> arch dir reorganized.
>
>  arch/nios2/include/asm/gpio.h |   52 +++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 52 insertions(+), 0 deletions(-)
>  create mode 100644 arch/nios2/include/asm/gpio.h
>
> diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h
> new file mode 100644
> index 0000000..cd2df7d
> --- /dev/null
> +++ b/arch/nios2/include/asm/gpio.h
> @@ -0,0 +1,52 @@
> +/*
> + * nios2 gpio driver
> + *
> + * This gpio core is described in http://nioswiki.com/GPIO
> + * bit[0] data
> + * bit[1] output enable
> + *
> + * when CONFIG_SYS_GPIO_BASE is not defined, board may provide
> + * its own driver.
> + *
> + * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef _ASM_NIOS2_GPIO_H_
> +#define _ASM_NIOS2_GPIO_H_ 1
> +
> +#ifdef CONFIG_SYS_GPIO_BASE
> +#include <asm/io.h>
> +
> +static inline int gpio_direction_input(unsigned gpio)
> +{
> +	writel(1, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
>   
> +	return 0;
> +}
> +
> +static inline int gpio_direction_output(unsigned gpio, int value)
> +{
> +	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
> +	return 0;
> +}
> +
> +static inline int gpio_get_value(unsigned gpio)
> +{
> +	return readl(CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
> +}
> +
> +static inline void gpio_set_value(unsigned gpio, int value)
> +{
> +	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
> +}
>   

   Why enclose 'gpio' into () when it's not within a macro?

WBR, Sergei

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v3] nios2: add gpio support
  2010-04-17 14:18   ` Sergei Shtylyov
@ 2010-04-17 14:50     ` Thomas Chou
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Chou @ 2010-04-17 14:50 UTC (permalink / raw)
  To: u-boot

On 04/17/2010 10:18 PM, Sergei Shtylyov wrote:
>> +static inline void gpio_set_value(unsigned gpio, int value)
>> +{
>> +    writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
>> +}
>
>
>   Why enclose 'gpio' into () when it's not within a macro?
>
Hi Sergei,

Right. It is not not needed. Thanks.

Best regards,
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v4] nios2: add gpio support
  2010-03-26 11:18 [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
  2010-03-26 22:31 ` [U-Boot] [PATCH v2] " Thomas Chou
  2010-04-17 12:16 ` [U-Boot] [PATCH v3] nios2: add gpio support Thomas Chou
@ 2010-04-17 15:02 ` Thomas Chou
  2 siblings, 0 replies; 6+ messages in thread
From: Thomas Chou @ 2010-04-17 15:02 UTC (permalink / raw)
  To: u-boot

This patch adds driver for a trivial gpio core, which is described
in http://nioswiki.com/GPIO. It is used for gpio led and nand flash
interface in u-boot.

When CONFIG_SYS_GPIO_BASE is not defined, board may provide
its own driver.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
remove () from gpio when it is not in a macro.

 arch/nios2/include/asm/gpio.h |   52 +++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)
 create mode 100644 arch/nios2/include/asm/gpio.h

diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h
new file mode 100644
index 0000000..76c425e
--- /dev/null
+++ b/arch/nios2/include/asm/gpio.h
@@ -0,0 +1,52 @@
+/*
+ * nios2 gpio driver
+ *
+ * This gpio core is described in http://nioswiki.com/GPIO
+ * bit[0] data
+ * bit[1] output enable
+ *
+ * when CONFIG_SYS_GPIO_BASE is not defined, board may provide
+ * its own driver.
+ *
+ * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _ASM_NIOS2_GPIO_H_
+#define _ASM_NIOS2_GPIO_H_
+
+#ifdef CONFIG_SYS_GPIO_BASE
+#include <asm/io.h>
+
+static inline int gpio_direction_input(unsigned gpio)
+{
+	writel(1, CONFIG_SYS_GPIO_BASE + (gpio << 2));
+	return 0;
+}
+
+static inline int gpio_direction_output(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + (gpio << 2));
+	return 0;
+}
+
+static inline int gpio_get_value(unsigned gpio)
+{
+	return readl(CONFIG_SYS_GPIO_BASE + (gpio << 2));
+}
+
+static inline void gpio_set_value(unsigned gpio, int value)
+{
+	writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + (gpio << 2));
+}
+#else
+extern int gpio_direction_input(unsigned gpio);
+extern int gpio_direction_output(unsigned gpio, int value);
+extern int gpio_get_value(unsigned gpio);
+extern void gpio_set_value(unsigned gpio, int value);
+#endif /* CONFIG_SYS_GPIO_BASE */
+
+#endif /* _ASM_NIOS2_GPIO_H_ */
-- 
1.6.6.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-04-17 15:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 11:18 [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
2010-03-26 22:31 ` [U-Boot] [PATCH v2] " Thomas Chou
2010-04-17 12:16 ` [U-Boot] [PATCH v3] nios2: add gpio support Thomas Chou
2010-04-17 14:18   ` Sergei Shtylyov
2010-04-17 14:50     ` Thomas Chou
2010-04-17 15:02 ` [U-Boot] [PATCH v4] " Thomas Chou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox