From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] nios2: add gpio support
Date: Sat, 17 Apr 2010 22:50:39 +0800 [thread overview]
Message-ID: <4BC9CABF.8080000@wytron.com.tw> (raw)
In-Reply-To: <4BC9C350.1030902@mvista.com>
On 04/17/2010 10:18 PM, Sergei Shtylyov wrote:
>> +static inline void gpio_set_value(unsigned gpio, int value)
>> +{
>> + writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2));
>> +}
>
>
> Why enclose 'gpio' into () when it's not within a macro?
>
Hi Sergei,
Right. It is not not needed. Thanks.
Best regards,
Thomas
next prev parent reply other threads:[~2010-04-17 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 11:18 [U-Boot] [PATCH] nios2: add gpio support with asm-nios2/gpio.h Thomas Chou
2010-03-26 22:31 ` [U-Boot] [PATCH v2] " Thomas Chou
2010-04-17 12:16 ` [U-Boot] [PATCH v3] nios2: add gpio support Thomas Chou
2010-04-17 14:18 ` Sergei Shtylyov
2010-04-17 14:50 ` Thomas Chou [this message]
2010-04-17 15:02 ` [U-Boot] [PATCH v4] " Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC9CABF.8080000@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox