From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Sat, 17 Apr 2010 22:50:39 +0800 Subject: [U-Boot] [PATCH v3] nios2: add gpio support In-Reply-To: <4BC9C350.1030902@mvista.com> References: <1269602322-6319-1-git-send-email-thomas@wytron.com.tw> <1271506572-2843-1-git-send-email-thomas@wytron.com.tw> <4BC9C350.1030902@mvista.com> Message-ID: <4BC9CABF.8080000@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/17/2010 10:18 PM, Sergei Shtylyov wrote: >> +static inline void gpio_set_value(unsigned gpio, int value) >> +{ >> + writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2)); >> +} > > > Why enclose 'gpio' into () when it's not within a macro? > Hi Sergei, Right. It is not not needed. Thanks. Best regards, Thomas