From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rix Date: Sat, 17 Apr 2010 16:09:12 -0500 Subject: [U-Boot] [PATCH] pm9263 converted to at91 soc access In-Reply-To: <4BC4208C.80303@ronetix.at> References: <1270632801-9399-1-git-send-email-dimov@ronetix.at> <4BC3A646.1000502@windriver.com> <4BC4208C.80303@ronetix.at> Message-ID: <4BCA2378.4060702@bumblecow.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de RONETIX - Asen Dimov wrote: > Tom wrote: >> Asen Dimov wrote: >>> Signed-off-by: Asen Dimov >>> --- >>> board/ronetix/pm9263/led.c | 15 ++-- >>> board/ronetix/pm9263/pm9263.c | 195 >>> +++++++++++++++++++++-------------------- >>> include/configs/pm9263.h | 82 ++++++++--------- >>> 3 files changed, 146 insertions(+), 146 deletions(-) >>> + >>> /* Enable clock */ >>> - at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9263_ID_PIOB | >>> - 1 << AT91SAM9263_ID_PIOCDE); >>> + writel(1 << AT91SAM9263_ID_PIOB, &pmc->pcer); >> Missing PICOCDE.. >> Is this ok ? >> > The two leds are on PIOB, no leds on PIO: C, D or E. > It is ok. >>> ok >>> - at91_set_gpio_output(CONFIG_RED_LED, 1); >>> - at91_set_gpio_output(CONFIG_GREEN_LED, 1); >>> - csa | AT91_MATRIX_EBI0_CS3A_SMC_SMARTMEDIA); >>> + csa = readl(&matrix->csa[0]) | AT91_MATRIX_CSA_EBI_CS3A; >>> + writel(csa, &matrix->csa[0]); >> Missing SMARTMEDIA >> Is this ok? >> > AT91_MATRIX_EBI0_CS3A_SMC_SMARTMEDIA sets the SMARTMEDIA bit and > AT91_MATRIX_CSA_EBI_CS3A sets the SMARTMEDIA bit too. > It is ok. ok >>> >>> /* Configure SMC CS3 for NAND/SmartMedia */ >>> + writel(1 << 25, &pio->pioc.puer); >>> + writel((1 << 25) | (1 << 26), &pio->pioe.puer); >>> >> There should be #defines for these values. >> There are similar cases where old #define's have be >> converted to bit ops. The old method of #defines is preferred > Ok. I will #define the values. >> Tom > Regards, > Asen Tom