From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time
Date: Mon, 19 Apr 2010 17:35:52 -0500 [thread overview]
Message-ID: <4BCCDAC8.1060105@freescale.com> (raw)
In-Reply-To: <20100419173404.46e54125.kim.phillips@freescale.com>
Kim Phillips wrote:
> On Mon, 19 Apr 2010 15:19:24 -0500
> Scott Wood <scottwood@freescale.com> wrote:
>> Shouldn't you be using icache_enable(), or at least using HID0_INIT to
>> do invalidation and lock clearing?
>
> the invalidation should occur whether or not the cache enable bit is
> set in HID0_INIT,
OK, was thinking of some other caches that don't automatically clear out
the random junk on power-on -- but e300 manual says it does.
> But I see your point; we should be using a more
> formal approach. I'll see what I can do - it's just that this patch
> preserved the existing code size, which could be important for e.g.,
> future nand bootstrap development.
Right. It looks like we could shrink the NAND SPL some more by
#ifndefing the cache functions in start.S.
-Scott
next prev parent reply other threads:[~2010-04-19 22:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 22:36 [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time Kim Phillips
2010-04-16 17:06 ` Michael Zaidman
2010-04-19 20:23 ` Kim Phillips
2010-04-19 20:19 ` Scott Wood
2010-04-19 22:34 ` Kim Phillips
2010-04-19 22:35 ` Scott Wood [this message]
2010-04-19 20:30 ` Timur Tabi
2010-04-19 20:41 ` Scott Wood
2010-04-19 21:05 ` Timur Tabi
2010-04-19 21:37 ` Kim Phillips
2010-04-20 1:39 ` Timur Tabi
2010-04-21 0:37 ` [U-Boot] [PATCH 3/3 v2] " Kim Phillips
2010-10-19 16:03 ` [U-Boot] ICACHE in core initialization to improve u-boot boot time: Breaks booting with i2c code while executing in flash Richard Retanubun
2010-10-20 19:50 ` Wolfgang Denk
2010-10-27 17:42 ` Richard Retanubun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCCDAC8.1060105@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox