From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 19 Apr 2010 17:35:52 -0500 Subject: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time In-Reply-To: <20100419173404.46e54125.kim.phillips@freescale.com> References: <20100415173609.e701a08b.kim.phillips@freescale.com> <20100419152345.0cb17200.kim.phillips@freescale.com> <4BCCBACC.6050801@freescale.com> <20100419173404.46e54125.kim.phillips@freescale.com> Message-ID: <4BCCDAC8.1060105@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kim Phillips wrote: > On Mon, 19 Apr 2010 15:19:24 -0500 > Scott Wood wrote: >> Shouldn't you be using icache_enable(), or at least using HID0_INIT to >> do invalidation and lock clearing? > > the invalidation should occur whether or not the cache enable bit is > set in HID0_INIT, OK, was thinking of some other caches that don't automatically clear out the random junk on power-on -- but e300 manual says it does. > But I see your point; we should be using a more > formal approach. I'll see what I can do - it's just that this patch > preserved the existing code size, which could be important for e.g., > future nand bootstrap development. Right. It looks like we could shrink the NAND SPL some more by #ifndefing the cache functions in start.S. -Scott