public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Failure in ubifsmount
Date: Tue, 20 Apr 2010 16:52:13 +0200	[thread overview]
Message-ID: <4BCDBF9D.4050103@denx.de> (raw)

Hi,

it seems I have found an unitialized variable when I run ubifsmount on
an ARM board.

The problem arises during the sget() function when the "type" of
filesystem is added to the superblock list, at the following line:

	list_add(&s->s_instances, &type->fs_supers);

I have checked that fs_supers has both pointers prev and next set to
zero. The pointer type is only a reference to the static structure
ubifs_fs_type, inside the same file, and the fs_supers is not
initialized at all.
Initializing the list with INIT_LIST_HEAD seems solving the problem,
after that ubifsmount works and I can load files with ubifsload.
However, I am not sure if this is enough (else I had sent a patch...).

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

             reply	other threads:[~2010-04-20 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 14:52 Stefano Babic [this message]
2010-04-21  7:15 ` [U-Boot] Failure in ubifsmount Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCDBF9D.4050103@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox