public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support	added for SPEAr SoCs
Date: Thu, 22 Apr 2010 10:15:32 +0530	[thread overview]
Message-ID: <4BCFD46C.5040204@st.com> (raw)
In-Reply-To: <1271850676.22118.8.camel@ptyser-laptop>

On 4/21/2010 5:21 PM, Peter Tyser wrote:
> Hi Vipin,
> 
> On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote:
>> Adding CONFIG_DISPLAY_CPUINFO and CONFIG_ARCH_CPU_INIT support for SPEAr3xx and
>> SPEAr6xx SoCs
>>
>> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
>> ---
>>  arch/arm/cpu/arm926ejs/spear/Makefile      |    3 +-
>>  arch/arm/include/asm/arch-spear/spr_misc.h |    5 ++
>>  cpu/arm926ejs/spear/cpu_info.c             |   76 ++++++++++++++++++++++++++++
> 
> The cpu path above needs to be adjusted to arch/arm/cpu/...
> 
Yes, I would do that in patch v2

> Also, cpu_info.c doesn't seem like the best filename.  You put both
> initialization code and informational code in it, so a more generic name
> such as "cpu.c" would be preferred.  Or possibly cpu.c and cpu_init.c.
> PowerPC boards would serve as a decent reference.
> 
Yes, I just thought about it sometime back and then forgot to change the
name. I would change the name to cpu.c

> Best,
> Peter
> 
Thanks
Vipin

  reply	other threads:[~2010-04-22  4:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21  7:54 [U-Boot] [PATCH 00/17] Network support for spear platform and spear1300 support Vipin KUMAR
2010-04-21  7:54 ` [U-Boot] [PATCH 01/17] u-boot.img file not created when srctree and objtree are different Vipin KUMAR
2010-04-21  7:54   ` [U-Boot] [PATCH 02/17] change_bit routine defined Vipin KUMAR
2010-04-21  7:54     ` [U-Boot] [PATCH 03/17] SPEAr : SMI erase and write timeouts increased Vipin KUMAR
2010-04-21  7:54       ` [U-Boot] [PATCH 04/17] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Vipin KUMAR
2010-04-21  7:54         ` [U-Boot] [PATCH 05/17] SPEAr : Reducing the max RAM size to 128MB Vipin KUMAR
2010-04-21  7:54           ` [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Vipin KUMAR
2010-04-21  7:54             ` [U-Boot] [PATCH 07/17] SPEAr : Network driver support added Vipin KUMAR
2010-04-21  7:54               ` [U-Boot] [PATCH 08/17] SPEAr : Network support configured for spear SoCs Vipin KUMAR
2010-04-21  7:54                 ` [U-Boot] [PATCH 09/17] SPEAr : macb driver support added for spear310 and spear320 Vipin KUMAR
2010-04-21  7:54                   ` [U-Boot] [PATCH 10/17] SPEAr : FSMC driver support added Vipin KUMAR
2010-04-21  7:54                     ` [U-Boot] [PATCH 11/17] SPEAr : Configuring FSMC driver for NAND interface Vipin KUMAR
2010-04-21  7:54                       ` [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c Vipin KUMAR
2010-04-21  7:54                         ` [U-Boot] [PATCH 13/17] SPEAr : smi driver moved completely into drivers/mtd Vipin KUMAR
2010-04-21  7:54                           ` [U-Boot] [PATCH 14/17] SPEAr : USBD driver support added Vipin KUMAR
2010-04-21  7:54                             ` [U-Boot] [PATCH 15/17] SPEAr : Basic spear1300 architecture " Vipin KUMAR
2010-04-21  7:54                               ` [U-Boot] [PATCH 16/17] SPEAr : spear1300 SoC " Vipin KUMAR
2010-04-21  7:54                                 ` [U-Boot] [PATCH 17/17] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Vipin KUMAR
2010-04-21 12:11                         ` [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c Peter Tyser
2010-04-22  4:07                           ` Vipin KUMAR
2010-04-21 17:02                       ` [U-Boot] [PATCH 11/17] SPEAr : Configuring FSMC driver for NAND interface Scott Wood
2010-04-22  4:21                         ` Vipin KUMAR
2010-04-22 15:39                           ` Scott Wood
2010-04-21 17:02                     ` [U-Boot] [PATCH 10/17] SPEAr : FSMC driver support added Scott Wood
2010-04-22  4:28                       ` Vipin KUMAR
2010-04-22 16:01                         ` Scott Wood
2010-04-21 12:00               ` [U-Boot] [PATCH 07/17] SPEAr : Network " Peter Tyser
2010-04-22  4:30                 ` Vipin KUMAR
2010-04-21 17:48               ` Ben Warren
2010-04-22  4:43                 ` Vipin KUMAR
2010-04-23 10:32                 ` Armando VISCONTI
2010-04-26  5:02                   ` Ben Warren
2010-04-26  8:01                     ` Armando VISCONTI
2010-04-26  8:34                       ` Vipin KUMAR
2010-04-21 11:51             ` [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Peter Tyser
2010-04-22  4:45               ` Vipin KUMAR [this message]
2010-04-21 11:54 ` [U-Boot] [PATCH 00/17] Network support for spear platform and spear1300 support Peter Tyser
2010-04-21 12:00   ` Vipin KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCFD46C.5040204@st.com \
    --to=vipin.kumar@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox