From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin KUMAR <vipin.kumar@st.com>
Date: Thu, 22 Apr 2010 10:15:32 +0530
Subject: [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support	added
 for SPEAr SoCs
In-Reply-To: <1271850676.22118.8.camel@ptyser-laptop>
References: <1271836483-15978-1-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-2-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-3-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-4-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-5-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-6-git-send-email-vipin.kumar@st.com>	
	<1271836483-15978-7-git-send-email-vipin.kumar@st.com>
	<1271850676.22118.8.camel@ptyser-laptop>
Message-ID: <4BCFD46C.5040204@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 4/21/2010 5:21 PM, Peter Tyser wrote:
> Hi Vipin,
> 
> On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote:
>> Adding CONFIG_DISPLAY_CPUINFO and CONFIG_ARCH_CPU_INIT support for SPEAr3xx and
>> SPEAr6xx SoCs
>>
>> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
>> ---
>>  arch/arm/cpu/arm926ejs/spear/Makefile      |    3 +-
>>  arch/arm/include/asm/arch-spear/spr_misc.h |    5 ++
>>  cpu/arm926ejs/spear/cpu_info.c             |   76 ++++++++++++++++++++++++++++
> 
> The cpu path above needs to be adjusted to arch/arm/cpu/...
> 
Yes, I would do that in patch v2

> Also, cpu_info.c doesn't seem like the best filename.  You put both
> initialization code and informational code in it, so a more generic name
> such as "cpu.c" would be preferred.  Or possibly cpu.c and cpu_init.c.
> PowerPC boards would serve as a decent reference.
> 
Yes, I just thought about it sometime back and then forgot to change the
name. I would change the name to cpu.c

> Best,
> Peter
> 
Thanks
Vipin