From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Fri, 23 Apr 2010 12:04:51 +0800
Subject: [U-Boot] [PATCH] mmc: add generic mmc spi driver
In-Reply-To: <201004222335.24320.vapier@gentoo.org>
References: <1271991214-7937-1-git-send-email-thomas@wytron.com.tw>
	<201004222335.24320.vapier@gentoo.org>
Message-ID: <4BD11C63.2050005@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/23/2010 11:35 AM, Mike Frysinger wrote:
> On Thursday 22 April 2010 22:53:34 Thomas Chou wrote:
>    
>> This patch supports mmc/sd card with spi interface.
>> I have tested with sd and mmc cards. But there is still ocr issue
>> with SDHC.
>>      
> now the semi-obvious question ... how does this differ from the old spi_mmc.c
> driver ?  i see this doesnt rely on the legacy mmc framework, but what about
> device/commandset support parity ?
>
>    
Hi Mike,

Right after playing your spi_mmc.c, I started this one based on generic 
mmc framework last night. I tried hard to recall my memory about mmc/sd, 
and hoped to catch up the merge window.

Do you mean "parity" as crc? Crc is not supported, but can be added. I 
make some command set translation when spi doesn't support.

> it's too bad the new framework doesnt allow for dynamic probing like the spi
> layer.  makes it a pain to work with a SPI/MMC card that can have the CS
> changed on the fly.
> -mike
>    
Maybe we can move spi_setup_slave to the mmc->init() and  do probing. Or 
shall we add a subcommand?

Cheers,
Thomas