From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Sun, 25 Apr 2010 19:55:27 -0400 Subject: [U-Boot] [PATCH] fdt_support: add entry for sec3.1 and remove tls_ssl_stream descriptor type capability for sec3.3 In-Reply-To: <20100423122011.7ebf068e.kim.phillips@freescale.com> References: <20100423122011.7ebf068e.kim.phillips@freescale.com> Message-ID: <4BD4D66F.6070800@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Kim, Haiying, Kim Phillips wrote: > Add sec3.1 h/w geometry for fdt node fixups. > > Also, technically, whilst SEC v3.3 h/w honours the tls_ssl_stream descriptor > type, it lacks the ARC4 algorithm execution unit required to be able > to execute anything meaningful with it. Change the node to agree with > the documentation that declares that the sec3.3 really doesn't have such > a descriptor type. > > Reported-by: Haiying Wang > Signed-off-by: Kim Phillips > --- > common/fdt_support.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/common/fdt_support.c b/common/fdt_support.c > index b6f252a..a8ac617 100644 > --- a/common/fdt_support.c > +++ b/common/fdt_support.c > @@ -534,7 +534,8 @@ void fdt_fixup_crypto_node(void *blob, int sec_rev) > { 0x0202, 1, 24, 0x04c, 0x0122003f }, /* SEC 2.2 */ > { 0x0204, 4, 24, 0x07e, 0x012b0ebf }, /* SEC 2.4 */ > { 0x0300, 4, 24, 0x9fe, 0x03ab0ebf }, /* SEC 3.0 */ > - { 0x0303, 4, 24, 0x97c, 0x03ab0abf }, /* SEC 3.3 */ > + { 0x0301, 4, 24, 0xbfe, 0x03ab0ebf }, /* SEC 3.1 */ > + { 0x0303, 4, 24, 0x97c, 0x03a30abf }, /* SEC 3.3 */ > }; > char compat_strlist[ARRAY_SIZE(sec_rev_prop_list) * > sizeof("fsl,secX.Y")]; Hmmm, we have two pieces of Freescale processor-specific fixups in fdt_support.c: #ifdef CONFIG_HAS_FSL_DR_USB void fdt_fixup_dr_usb(void *blob, bd_t *bd) : : #endif /* CONFIG_HAS_FSL_DR_USB */ #if defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) /* * update crypto node properties to a specified revision of the SEC * called with sec_rev == 0 if not on an mpc8xxxE processor */ void fdt_fixup_crypto_node(void *blob, int sec_rev) : : #endif /* defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) */ While I'm OK with the change and am willing to ack since it appears to be a small and necessary improvement to existing code, it would be better to move the Freescale specific fixups into a Freescale CPU subdirectory, probably cpu/mpc8xxx/fdt.c. Thanks, gvb