From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Sun, 25 Apr 2010 21:51:06 -0700 Subject: [U-Boot] [PATCH] net: dm9000x: use standard I/O accessors In-Reply-To: <1271276946-7318-1-git-send-email-vapier@gentoo.org> References: <1271276946-7318-1-git-send-email-vapier@gentoo.org> Message-ID: <4BD51BBA.2020807@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike, ApplOn 4/14/2010 1:29 PM, Mike Frysinger wrote: > The current dm9000x driver accesses its memory mapped registers directly > instead of using the standard I/O accessors. This can cause problems on > Blackfin systems as the accesses can get out of order. So convert the > direct volatile dereferences to use the normal in/out macros. > > Signed-off-by: Mike Frysinger > --- > drivers/net/dm9000x.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c > index a7fef56..f121286 100644 > --- a/drivers/net/dm9000x.c > +++ b/drivers/net/dm9000x.c > @@ -117,12 +117,12 @@ static void DM9000_iow(int reg, u8 value); > > /* DM9000 network board routine ---------------------------- */ > > -#define DM9000_outb(d,r) ( *(volatile u8 *)r = d ) > -#define DM9000_outw(d,r) ( *(volatile u16 *)r = d ) > -#define DM9000_outl(d,r) ( *(volatile u32 *)r = d ) > -#define DM9000_inb(r) (*(volatile u8 *)r) > -#define DM9000_inw(r) (*(volatile u16 *)r) > -#define DM9000_inl(r) (*(volatile u32 *)r) > +#define DM9000_outb(d,r) outb(d, r) > +#define DM9000_outw(d,r) outw(d, r) > +#define DM9000_outl(d,r) outl(d, r) > +#define DM9000_inb(r) inb(r) > +#define DM9000_inw(r) inw(r) > +#define DM9000_inl(r) inl(r) > > #ifdef CONFIG_DM9000_DEBUG > static void > Applied to net repo. thanks, Ben